This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Add support for UDSC Mint in Client #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | 9d6bc1c | packages/web/.env/.env.prod | View secret |
| - | Generic High Entropy Secret | 9d6bc1c | packages/web/.env/.env.prod | View secret |
| - | Generic High Entropy Secret | 9d6bc1c | packages/web/.env/.env.stage | View secret |
| - | Generic High Entropy Secret | 9d6bc1c | packages/web/.env/.env.stage | View secret |
| - | Generic High Entropy Secret | 7461dc5 | packages/mobile/.env.dev | View secret |
| - | Generic High Entropy Secret | 7461dc5 | packages/mobile/.env.prod | View secret |
| - | Generic High Entropy Secret | 7461dc5 | packages/mobile/.env.prod | View secret |
| - | Generic High Entropy Secret | 7461dc5 | packages/mobile/.env.stage | View secret |
| - | Generic High Entropy Secret | 7461dc5 | packages/mobile/.env.stage | View secret |
| 688750 | Generic High Entropy Secret | bc80c8d | packages/web/.env/.env.dev | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
sliptype
approved these changes
Jul 20, 2023
dylanjeffers
added a commit
that referenced
this pull request
Jul 24, 2023
[72ec48f] Upgrade to 1.5.33 Dylan Jeffers [9ec1f54] Update to reroute to trending when deleting a playlist if the playlist is viewed (#3789) Kyle Shanks [5cbc230] [C-2877] Address suggested-tracks qa #2 (#3787) Dylan Jeffers [4ad7987] [PAY-1652] Update LockedContentDrawer on mobile (#3786) Reed [5e2337c] Fix mobile premcontent locked badge colors (#3783) Reed [19cca4c] Change mobile drawer background to white (#3784) Reed [05b7d1f] [PAY-1635] Always show share button for track owners on hidden tracks (#3782) Randy Schott [ca66d4d] [PAY-1575] Always show premium DogEars on track details page (#3781) Randy Schott [46f41a8] [PAY-1620] Fix disabled play button for unlocked gated tracks on Mobile Web (#3779) Randy Schott [44666b2] [PAY-1615] Fix display of "Artist Pick" text (#3780) Randy Schott [3e24539] [PAY-1618] Update DogEar rendering and fix spacing (#3775) Randy Schott [bb28a09] [C-2866] Undo secondary button style changes (#3777) Randy Schott [699f8f6] [PAY-1634] Fix hidden track tile + add share button (#3765) Reed [1d95e73] Add support for UDSC Mint in Client (#3776) Marcus Pasell [79d85f1] [PAY-1638] Fix iconLockUnlocked icon (#3766) Reed [b63107b] [C-2872] Fix image retries (#3773) Dylan Jeffers [b99b93a] Add fallback url to embed (#3772) Raymond Jacobson [5adb25b] Remove usages of CN /health_check/verbose (#3769) Theo Ilie [62a0c72] [C-2846] Suggested Tracks QA (#3771) Dylan Jeffers [9c87fb2] [C-2861] Replace private with hidden (#3768) Dylan Jeffers [87f7f35] [C-2650] Add playlist-library sanitization hook (#3767) Dylan Jeffers [8ba6d04] Add Dapp store publishing in CI (#3747) Raymond Jacobson [9324a06] [C-2842] Improve playlist image generation (#3762) Dylan Jeffers [9c5a412] Remove unused notification announcement page (#3739) Reed [5023cef] [C-2853] Fix deletedCount calculation (#3763) Andrew Mendelsohn [b627216] [PAY-1639] Fix mobile hidden track dog ear (#3764) Reed [40ea57e] [C-2856] Fix track/collection artwork field (#3760) Dylan Jeffers [366e4df] [C-2858] Fix phantom signing (#3761) Raymond Jacobson [8a7cbc7] [PAY-1621] Reverse order of mobile lineup tile stat icon and number (#3759) Reed [9206ab0] [PAY-1612] Change mobile hidden track header color (#3758) Reed [745ff35] Use Text component in mobile DMs (#3749) Reed [1afc426] [PAY-1607] Fix mobile prem content track tile layout (#3757) Reed [07f0f6c] [PAY-1606] Updates gated content experience (#3754) Randy Schott [a82e296] v1.5.32 Dylan Jeffers
dharit-tan
pushed a commit
that referenced
this pull request
Jul 24, 2023
[72ec48f] Upgrade to 1.5.33 Dylan Jeffers [9ec1f54] Update to reroute to trending when deleting a playlist if the playlist is viewed (#3789) Kyle Shanks [5cbc230] [C-2877] Address suggested-tracks qa #2 (#3787) Dylan Jeffers [4ad7987] [PAY-1652] Update LockedContentDrawer on mobile (#3786) Reed [5e2337c] Fix mobile premcontent locked badge colors (#3783) Reed [19cca4c] Change mobile drawer background to white (#3784) Reed [05b7d1f] [PAY-1635] Always show share button for track owners on hidden tracks (#3782) Randy Schott [ca66d4d] [PAY-1575] Always show premium DogEars on track details page (#3781) Randy Schott [46f41a8] [PAY-1620] Fix disabled play button for unlocked gated tracks on Mobile Web (#3779) Randy Schott [44666b2] [PAY-1615] Fix display of "Artist Pick" text (#3780) Randy Schott [3e24539] [PAY-1618] Update DogEar rendering and fix spacing (#3775) Randy Schott [bb28a09] [C-2866] Undo secondary button style changes (#3777) Randy Schott [699f8f6] [PAY-1634] Fix hidden track tile + add share button (#3765) Reed [1d95e73] Add support for UDSC Mint in Client (#3776) Marcus Pasell [79d85f1] [PAY-1638] Fix iconLockUnlocked icon (#3766) Reed [b63107b] [C-2872] Fix image retries (#3773) Dylan Jeffers [b99b93a] Add fallback url to embed (#3772) Raymond Jacobson [5adb25b] Remove usages of CN /health_check/verbose (#3769) Theo Ilie [62a0c72] [C-2846] Suggested Tracks QA (#3771) Dylan Jeffers [9c87fb2] [C-2861] Replace private with hidden (#3768) Dylan Jeffers [87f7f35] [C-2650] Add playlist-library sanitization hook (#3767) Dylan Jeffers [8ba6d04] Add Dapp store publishing in CI (#3747) Raymond Jacobson [9324a06] [C-2842] Improve playlist image generation (#3762) Dylan Jeffers [9c5a412] Remove unused notification announcement page (#3739) Reed [5023cef] [C-2853] Fix deletedCount calculation (#3763) Andrew Mendelsohn [b627216] [PAY-1639] Fix mobile hidden track dog ear (#3764) Reed [40ea57e] [C-2856] Fix track/collection artwork field (#3760) Dylan Jeffers [366e4df] [C-2858] Fix phantom signing (#3761) Raymond Jacobson [8a7cbc7] [PAY-1621] Reverse order of mobile lineup tile stat icon and number (#3759) Reed [9206ab0] [PAY-1612] Change mobile hidden track header color (#3758) Reed [745ff35] Use Text component in mobile DMs (#3749) Reed [1afc426] [PAY-1607] Fix mobile prem content track tile layout (#3757) Reed [07f0f6c] [PAY-1606] Updates gated content experience (#3754) Randy Schott [a82e296] v1.5.32 Dylan Jeffers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes breaking libs change
Also makes
npm run sdk:linknot actually compile things, just link them.Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Linked libs locally and have been using this to test USDC changes.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.