Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Donation Block]: Selected donation interval and amount is not visible #30811

Closed
karenroldan opened this issue May 19, 2023 · 2 comments · Fixed by #30864
Closed

[Donation Block]: Selected donation interval and amount is not visible #30811

karenroldan opened this issue May 19, 2023 · 2 comments · Fixed by #30864
Assignees
Labels
[Block] Donations Needs triage Ticket needs to be triaged [Platform] Atomic [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Status] In Progress [Type] Bug When a feature is broken and / or not performing as intended User Report

Comments

@karenroldan
Copy link
Contributor

Impacted plugin

Jetpack

Quick summary

The title for the chosen donation interval isn't visible as its color is set to #FFF (white). Similarly, the selected donation amount doesn't stand out, because its color remains the same as when it's inactive. The only indication of a successful selection is the activation of the Donate button.

Steps to reproduce

  1. Add a Donation block
  2. View the block on the live page
  3. Select any interval
  4. Choose an amount

Screen Capture on 2023-05-19 at 08-49-19

A clear and concise description of what you expected to happen.

When a donation interval or amount is selected, I expect a clear visual indication of the selection. The color of the selected option should change, making it distinct from the inactive options.

What actually happened

Selected donation interval and amount are not visible.

Impact

One

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Atomic

Logs or notes

  • Third-party theme (Scribe Theme (Kadence) • Restored 316)
.wp-block-jetpack-donations .donations__nav-item.is-active {
    background: var(--wp-admin-theme-color);
    color: #fff;
    cursor: default;
}
.wp-block-jetpack-donations .donations__amount.is-selected {
    box-shadow: 0 0 0 1px #fff,0 0 0 3px var(--wp-admin-theme-color);
    outline: 2px solid transparent;
    outline-offset: -2px;
}
@karenroldan karenroldan added [Type] Bug When a feature is broken and / or not performing as intended [Block] Donations User Report Needs triage Ticket needs to be triaged labels May 19, 2023
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Platform] Atomic [Pri] Low labels May 19, 2023
@jeherve
Copy link
Member

jeherve commented May 22, 2023

Could you let us know what theme you were using on your site, to make things easier to reproduce?

Thank you!

@karenroldan
Copy link
Contributor Author

Could you let us know what theme you were using on your site, to make things easier to reproduce?

Hi! It's a third-party theme: Scribe Theme (Kadence) by Restored 316.

jeherve added a commit that referenced this issue May 23, 2023
Fixes #30811

Follow-up from #16687

The Donations block uses a common stylesheet that is used in the block editor and on the frontend, where css vars like `--wp-admin-theme-color` are not available. Let's switch to using a color that will be available on the frontend.
kraftbj pushed a commit that referenced this issue May 23, 2023
Fixes #30811

Follow-up from #16687

The Donations block uses a common stylesheet that is used in the block editor and on the frontend, where css vars like `--wp-admin-theme-color` are not available. Let's switch to using a color that will be available on the frontend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Donations Needs triage Ticket needs to be triaged [Platform] Atomic [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Status] In Progress [Type] Bug When a feature is broken and / or not performing as intended User Report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants