Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donations Block: do not use admin color on the frontend #30864

Merged
merged 2 commits into from
May 23, 2023

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented May 23, 2023

Fixes #30811

Proposed changes:

Follow-up from #16687

The Donations block uses a common stylesheet that is used in the block editor and on the frontend, where css vars like --wp-admin-theme-color are not available. Let's switch to using a color that will be available on the frontend.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Start with a site that's connected to WordPress.com.
  • Install the Kadence theme
  • Go to Posts > Add New and add a Donations block.
  • Make sure you can switch between tabs for donation frequency, and that the text is readable.
  • Make sure this works on the frontend as well.
  • Try with a different theme like Twenty Twenty Three.

Fixes #30811

Follow-up from #16687

The Donations block uses a common stylesheet that is used in the block editor and on the frontend, where css vars like `--wp-admin-theme-color` are not available. Let's switch to using a color that will be available on the frontend.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal Earn Earn features [Block] Donations labels May 23, 2023
@jeherve jeherve self-assigned this May 23, 2023
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label May 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: June 6, 2023.
  • Scheduled code freeze: May 29, 2023.

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack fix/donations-bg-color

to get started. More details: p9dueE-5Nn-p2

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 23, 2023
@kraftbj kraftbj enabled auto-merge (squash) May 23, 2023 22:44
@kraftbj kraftbj added this to the Jetpack/12.2 milestone May 23, 2023
@kraftbj kraftbj merged commit be6fdc7 into trunk May 23, 2023
@kraftbj kraftbj deleted the fix/donations-bg-color branch May 23, 2023 22:59
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Donations Earn Earn features [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Donation Block]: Selected donation interval and amount is not visible
2 participants