Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: update base-styles dependency #16687

Merged
merged 4 commits into from
Aug 24, 2020
Merged

Blocks: update base-styles dependency #16687

merged 4 commits into from
Aug 24, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Aug 3, 2020

Changes proposed in this Pull Request:

  • This PR is a split from Update wordpress monorepo #15157. Here, I updated the @wordpress/base-styles package and updated all blocks where we leveraged core colors according to recent changes in Core:

This updates quite a few blocks to use those new colors. Here are some examples:

screenshot 2020-08-03 at 14 31 00

screenshot 2020-08-03 at 14 30 00

screenshot 2020-08-03 at 14 28 24

screenshot 2020-08-03 at 14 27 46

screenshot 2020-08-03 at 14 26 23

screenshot 2020-08-03 at 14 25 19

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • N/A

Testing instructions:

  • Go to Posts > Add New
  • Add and play with blocks, and see if you notice any weirdness.

Proposed changelog entry for your changes:

  • Blocks: update to use latest colors defined by WordPress.

@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Status] Needs Design Review Design has been added. Needs a review! [Type] Janitorial [Pri] Normal [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Build labels Aug 3, 2020
@jeherve jeherve added this to the 8.9 milestone Aug 3, 2020
@jeherve jeherve self-assigned this Aug 3, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D47470-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot
Copy link

jetpackbot commented Aug 3, 2020 •
edited
Loading

Warnings
⚠️

pre-commit hook was skipped for one or more commits

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16687

Generated by 🚫 dangerJS against d7d6c3d

@jeherve jeherve mentioned this pull request Aug 10, 2020
Closed
1 task
@kraftbj kraftbj added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Aug 12, 2020
@kraftbj
Copy link
Contributor

kraftbj commented Aug 12, 2020

Needs a rebase, but looks good. Once rebased, let's see if we can get design to fast-track review so we can avoid it going stale again.

@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Status] Needs Design Review Design has been added. Needs a review! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Design Review Design has been added. Needs a review! labels Aug 19, 2020
keoshi
keoshi previously approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested most of the components updated in this PR and they all look good.

Left a suggestion, but it's a minor one and shouldn't block merging this.

extensions/blocks/contact-form/editor.scss Outdated Show resolved Hide resolved
@keoshi keoshi removed the [Status] Needs Design Review Design has been added. Needs a review! label Aug 19, 2020
@jeherve @keoshi
Update extensions/blocks/contact-form/editor.scss
d7d6c3d 
Co-authored-by: Filipe Varela <keoshi@keoshi.com>
keoshi
keoshi approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving these changes once again — LGTM!

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Aug 21, 2020
@jeherve jeherve merged commit e996569 into master Aug 24, 2020
@jeherve jeherve deleted the update/base-styles-210 branch August 24, 2020 10:51
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Aug 24, 2020
@jeherve
Copy link
Member Author

jeherve commented Aug 24, 2020

r212552-wpcom

jeherve added a commit that referenced this pull request Aug 25, 2020
@jeherve
Changelog: add #16687
41fcc13
pereirinha pushed a commit that referenced this pull request Sep 10, 2020
@jeherve @keoshi @pereirinha
[not verified] Blocks: update base-styles dependency (#16687)
79e11c1 
Co-authored-by: Filipe Varela <keoshi@keoshi.com>
jeherve added a commit that referenced this pull request May 23, 2023
@jeherve
Donations Block: do not use admin color on the frontend
6051d7e 
Fixes #30811

Follow-up from #16687

The Donations block uses a common stylesheet that is used in the block editor and on the frontend, where css vars like `--wp-admin-theme-color` are not available. Let's switch to using a color that will be available on the frontend.
@jeherve jeherve mentioned this pull request May 23, 2023
Merged
3 tasks
kraftbj pushed a commit that referenced this pull request May 23, 2023
@jeherve
Donations Block: do not use admin color on the frontend (#30864)
be6fdc7 
Fixes #30811

Follow-up from #16687

The Donations block uses a common stylesheet that is used in the block editor and on the frontend, where css vars like `--wp-admin-theme-color` are not available. Let's switch to using a color that will be available on the frontend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

@keoshi keoshi keoshi approved these changes

Assignees

@jeherve jeherve

Labels
Build [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
8.9
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @matticbot @jetpackbot @kraftbj @keoshi