fix: remove check for default meta values that isn’t working

[dkoo]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Could be a chore, too, because it doesn't change any behavior in the plugin. But it removes a check and condition that isn't working. Because register_meta is happening on the init hook, it's too early to determine the post type, so the default values for several meta fields are always inherit. This PR makes this explicit.

Related to Automattic/newspack-theme#2061 but isn't a blocker to that PR.

How to test the changes in this Pull Request:

Nothing really to test—you can confirm that get_post_meta with the following fields always returns inherit by default:

• newspack_sponsor_sponsorship_scope
• newspack_sponsor_native_byline_display
• newspack_sponsor_underwriter_style
• newspack_sponsor_underwriter_placement

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[dkoo]

The test-js CI job failed due to some NPM errors, but this repo contains no JS tests, so merging.

[matticbot]

🎉 This PR is included in version 1.10.7-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 1.10.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀