Purchases: Make credit card page more flexible #7499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consider it initialized when the correct number of sites is loaded.
This is to ensure we have the site selected before continuing on with the other page components.
- Add 200ms delay to show Popover
I'm receiving the following error when submitting a AUTH_DECLINE card: Other than that the changes look good. |
When using Calypso components within a wp-admin page, the scss imports have to be done within a nested context. Otherwise, one gets css class naming conflicts. In order to make this work, all Calypso components need to exist under an html element with the given class. This commit allows RootChild to be set with the css class needed to support the nested context for scss imports.
|
@prettyboymp Thanks for a review! Good catch, we probably need to add a check when submitting form :) I'll fix that one. |
gziolo
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
…n-omit Card Component: Tighten Child Props Omissions
Component [Popover] Enable setting of className for RootChild
…rm-selector Editor: use EditorTermSelector for categories
Editor: Fix breaking linting errors.
* Define initial structure for plan-purchase-features * Add initial plan-purchase-features/features-list * Add initial render logic to PlanPurchaseFeatures * Add PlanPurchaseFeatures to devdocs * Fix displayName in devdocs of PlanPurchaseFeatures * Add styles to PlanPurchaseFeatures * Add more plan purchase features to features-list * Add custom domain feature This will need to be refactored once #7311 lands in. * Add GoogleVoucher to plan purchase features list * Connect PlanPurchaseFeatures to Redux Store * Add getPremiumFeatures method to PlanPurchaseFeatures * Complete getBusinessFeatures in PlanPurchaseFeatures * Add getPersonalFeatures to PlanPurchaseFeatures * Add JetpackFeatures to PlanPurchaseFeatures list * Add Jetpack plans to PlanPurchaseFeatures * Add basic styling and flex alignment * Add wrapping <div> around PurchaseDetail and re-style * Add HappinessSupportFeature to PlanPurchaseFeatures Needs styling tweaks and/or HappinessSupport component tweaks. Maybe we should create brand new component for PlanPurchaseFeatures? * Add CurrentPlanHeaderFeature to PlanPurchaseFeatures * Add placeholder CSS styles for header feature Copy-edited from checkout-thank-you/style.scss * Fix PlanPurchaseFeatuers devdocs errors Props @gwwar for the `<QuerySites siteId={ myPrimarySite } />` suggestion. * Use column-count instead of flexbox Props @rralian for the suggestion. * Move plan purchase features to their own files * Move plan purchase featuers logic into feature files * Split Jetpack featuers to own files * Use selectedSite from Redux site if not null * Divide Jetpack features to Free, Premium and Business * Add responsive styling for smaller devices * Reorder plan purchase features to match My Plan page * Make btns 100% width and center text on mobile * Import find from lodash (fix IE11 error with native find)
Add warning for ES6 instance functions in development environment
* Signup: Add eCommerce partners to store options for AB testing Adds BlueHost and SiteGround as store options of design type step. We need them in order to enable AB testing of eCommerce partner hosts.
* Wordads status redux Redux site stickers Add missing bracket after rebase Add tests to stickers reducer tree Fix notice Modify stickers to wordads status * Fixes * Add required proptypes * selector siteWordadsUnsafe -> isSiteWordadsUnsafe * New and shiny schema * Murican! * comments * Schema get rid of required * Schema again * Remove extra import
Delete Site: toLowerCase() before validating domain
Purchases: Extract CreditCardPage component
gziolo
force-pushed
the
update/improve-credit-card-page
branch
from
8c104d8 to
3105c04
Compare
|
I rebases with master and can't change this PR to diff with master. Closing this one in favor of #7537. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up for #7484.
In this PR I added another couple of refactorings:
<AddCardDetails />) and Edit Card Details (<EditCardDetails />) pages<PurchaseCardDetails />was extracted and contains shared logic for Card components that operates on purchases.../payment/editurl was updated to better reflect functionality of the page -.../payment/addWith that in place we should be ready to work on new flow for Connect for WooCommerce.
Testing.
isMountedchange is working properly. There should be no warnings on JS console complaining about incorrectsetStateusage.Test live: https://calypso.live/?branch=update/improve-credit-card-page