refactor: representing TxHash as Fr
#10954
Open
+127
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesjan
changed the title
TxHash as Fr
benesjan
commented
Dec 24, 2024
| @@ -15,6 +15,6 @@ struct ProposeArgs { | |||
|
|
|||
| library ProposeLib { | |||
| function digest(ProposeArgs memory _args) internal pure returns (bytes32) { | |||
| return keccak256(abi.encode(SignatureLib.SignatureDomainSeperator.blockAttestation, _args)); | |||
| return keccak256(abi.encode(SignatureLib.SignatureDomainSeparator.blockAttestation, _args)); | |||
There was a problem hiding this comment.
This typo was in a lot of places and it bothered me. Sorry for the messy diff
benesjan
commented
Dec 24, 2024
| const owner = AztecAddress.fromBuffer(reader); | ||
| const contractAddress = AztecAddress.fromBuffer(reader); | ||
| const storageSlot = Fr.fromBuffer(reader); | ||
| const note = reader.readObject(Note); |
There was a problem hiding this comment.
Unnecessary change but I thought it will make it cuter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TxHash used to be representing as Buffer32 and it did not make sense as it's an Fr.
+ typo fixes