Multi-Output Binding Analyzer #2440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satvu
commented
May 3, 2024
| /// <summary> | ||
| /// CodeAction implementation which adds the HttpResultAttribute on the return type of a function using the multi-output bindings pattern. | ||
| /// </summary> | ||
| private sealed class AddHttpResultAttribute : CodeAction |
There was a problem hiding this comment.
Debating on the necessity of a code-fix as we want the user to add the attribute where they want it, but we can assume that this case (use of IActionResult in multi-output binding scenario) will be pretty common.
satvu
commented
May 3, 2024
| var newPropertyNode = propertyNode | ||
| .AddAttributeLists(SyntaxFactory.AttributeList(SyntaxFactory.SingletonSeparatedList(attribute))); | ||
|
|
||
| var newRoot = root.ReplaceNode(propertyNode, newPropertyNode); |
There was a problem hiding this comment.
Still working on getting the formatting correct for the fix (ideally using Roslyn Formatter). The PR is failing the test I have for this due to the indentation issue.
satvu
commented
May 3, 2024
| } | ||
| } | ||
|
|
||
| private static bool IsCustomType(ISymbol symbol) |
There was a problem hiding this comment.
Would like reviews/ideas on how to approach determining whether or not a return type is a POCO.
satvu
commented
May 3, 2024
| new PackageIdentity("Microsoft.Azure.Functions.Worker.Extensions.Abstractions", "5.0.0"), | ||
| new PackageIdentity("Microsoft.AspNetCore.Mvc.Core", "2.2.5"), | ||
| new PackageIdentity("Microsoft.Extensions.Hosting.Abstractions", "6.0.0"), | ||
| new PackageIdentity("Microsoft.Azure.Functions.Worker.Extensions.Http", "3.2.0-local"))); |
There was a problem hiding this comment.
Needs to be updated once the actual package is released.
* Fix SignalR extensions DI issue * Make it idempotent `AddHostedService` with implementation type as `IHostedService` is forbidden.
The `_FunctionsPreBuild` msbuild target is currently being redefined.
* Adding context propagation for ActivityTraceFlags and TraceState.
* Fix incorrect build message * update release_notes.md * Refactor AzureFunctionVersion default and error checks * Add warning for v3 out of support * Address PR comments
…tedLinuxPlaceholder profile. FNH 1.0.10 (#2629) Removing WEBSITE_CONTAINER_READY=0 env variable check for DotnetIsolatedLinuxPlaceholder profile. Bumped version to 1.0.10
…ctionsNetHost Linux artifact (#2653) - Bumping patch version. New version is 1.0.11
…make the catch/rethrow effective
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #2352
Pull request checklist
release_notes.mdAdditional information
Tests need to be updated to use released packages following the release of the http extension (depends on host 4.34).