Fleet bump for manifest template #444
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgamero
reviewed
Dec 12, 2024
| DEPLOYMENT_MANIFEST_PATH: {{ .Config.GetVariableValue "DEPLOYMENTMANIFESTPATH" }} | ||
| DOCKER_FILE: {{ .Config.GetVariableValue "DOCKERFILE" }} | ||
| BUILD_CONTEXT_PATH: {{ .Config.GetVariableValue "BUILDCONTEXTPATH" }} | ||
| NAMESPACE: {{ .Config.GetVariableValue "NAMESPACE" }} | ||
| RESOURCE_TYPE: Microsoft.ContainerService/{{ .Config.GetVariableValue "RESOURCETYPE" }} |
There was a problem hiding this comment.
as this resource is always a cluster, it may make sense to call it "cluster resource type" to follow the convention used in this template
Signed-off-by: Manasa Chinta <manasachinta7@gmail.com> Co-authored-by: Tommy Barnes <thomas.jonathan.barnes@gmail.com> Co-authored-by: Brandon Foley <brandonfoley13@gmail.com> Co-authored-by: David Gamero <david340804@gmail.com>
…mpatible (Azure#371) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tom Gamble <thomasgamble2@gmail.com> Co-authored-by: Israel Miller <ismille@microsoft.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brandon Foley <brandonfoley13@gmail.com>
audrastump
force-pushed
the
fleetBump
branch
from
6cd04df to
d7f2c16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include the related issue if relevant, and motivation/context. Please also list any dependencies required for this change.
Fixes # (issue)
Feature # (details)
Type of change
How Has This Been Tested?
Provide instructions so we can reproduce, and list any relevant details for your test configuration. Please mention if this is a breaking change which will impact consuming tool(s).
Checklist: