localized diary topics #1159

AndreasBrostrom · 2019-06-11T19:20:01Z

When merged this pull request will:

Removed date topic from the diary records (New function from indev)
Added localized topic using pre existing localization strings.

addons/help/XEH_postInit.sqf

commy2 · 2019-06-12T06:35:28Z

How to turn a draft into a pull request?

Does this error with current release?

dedmen · 2019-06-12T07:42:59Z

How to turn a draft into a pull request?

dedmen · 2019-06-12T07:48:57Z

While at this, people have been asking for a way to hide diary records
https://forums.bohemia.net/forums/topic/223694-remove-diary-records-from-mods-or-others-already-there/?tab=comments#comment-3361406
Maybe add a setting or variable to disable creation of it?

AndreasBrostrom · 2019-06-12T10:59:49Z

Will make the adjustments digested above
and while at it; I can make a setting to disable the records as well for this pull request.

Does this error with current release?

Higly likely; don't know to be honest. Was also the reason why I made a draft of it.

commy2 · 2019-06-12T11:36:20Z

digested

Suggested? Please don't eat the pull request.

AndreasBrostrom · 2019-06-12T15:57:12Z

haha phone autocorrect, yes suggested.

AndreasBrostrom · 2019-06-12T16:55:28Z

AndreasBrostrom · 2019-06-12T19:10:48Z

Setting is local.

AndreasBrostrom · 2019-06-13T10:30:22Z

All done ready for review.

I am unsure if the setting handeling is a good solution. But the postInit did not handle anything else so no point running the rest.

commy2 · 2019-06-13T16:19:26Z

Not a fan of making a setting for this. It seems to me that the overhead of a setting, even though small, is not worth such a minor thing as some briefing entries.
The guy on the BIF even said that they had (and lost) a solution in the past that did just mission stuff to hide the diary entries. I would prefer if we just rediscover that solution and put it on the wiki.

AndreasBrostrom · 2019-06-13T18:23:16Z

Well I also removed all diaries once as well in a super hacky way but also lost that solution.

Tho there will be 2 new commands that allow scripts to remove diary records (removeDiarySubject, removeDiaryRecord). I stated this on the forum post as well.

Also unsure of the settings execution. But think it's neat to have the option to hide them.

commy2 · 2019-06-13T18:25:19Z

That settles it then. I'll doc it on the wiki. Setting not needed.

* draw scripted optic in pause menu in MP * draw scripted optic in pause menu in MP

AndreasBrostrom · 2019-06-14T19:07:32Z

Settings reverted

NOTE: This will cause error if used on version <1.95
New script parameter: createDiaryRecord

commy2

Don't merge before updated syntax of createDiaryRecord is in Arma stable.

commy2 · 2019-06-14T19:55:19Z

Remove will be:

player removeDiarySubject "cba_help_docs";

or:

player removeDiaryRecord ["cba_help_docs", localize "STR_CBA_Help_Keys"];
player removeDiaryRecord ["cba_help_docs", localize "STR_CBA_Credits"];
player removeDiaryRecord ["cba_help_docs", localize "STR_CBA_Addons"];

in next Arma stable I think.

* rotate scripted optic according to weapon bank * handle launchers, pistols * update variable names

* add cartridge effect on repeat * optimize * velocity one frame later to fix drawn position in frame 0 * update variable names

Add Missing Turkish Translations

XEH - Fix version report in rpt

Co-Authored-By: jonpas <jonpas33@gmail.com>

Add turret event

Replace all use of count as a forEach

…he sides to support 21:9 aspect ratio screens.

…r 21:9.

…h what you saw before scoping in. See CBATeam#1245 (comment) for comparison of old value.

…sues with increasing this value.

Add support for 21:9 resolutions to CBA optics addon.

… into NoDatedDiaryRecord

commy2 · 2019-10-30T18:55:47Z

0 spawn {
    waitUntil {!isNil "cba_help_DiaryRecordAddons"};

    // delete whole subject
    player removeDiarySubject "cba_help_docs";

    // or delete individual records
    player removeDiaryRecord ["cba_help_docs", cba_help_DiaryRecordKeys];
    player removeDiaryRecord ["cba_help_docs", cba_help_DiaryRecordCredits];
    player removeDiaryRecord ["cba_help_docs", cba_help_DiaryRecordAddons];
};

commy2 · 2019-10-30T19:02:07Z

fuck this shit

commy2 reviewed Jun 12, 2019

View reviewed changes

addons/help/XEH_postInit.sqf Outdated Show resolved Hide resolved

commy2 reviewed Jun 12, 2019

View reviewed changes

addons/help/XEH_postInit.sqf Outdated Show resolved Hide resolved

commy2 reviewed Jun 12, 2019

View reviewed changes

addons/help/XEH_postInit.sqf Outdated Show resolved Hide resolved

commy2 added the Enhancement label Jun 12, 2019

commy2 added this to the Ongoing milestone Jun 12, 2019

commy2 marked this pull request as ready for review June 12, 2019 07:54

AndreasBrostrom force-pushed the NoDatedDiaryRecord branch from 02bc113 to 120f466 Compare June 12, 2019 17:01

Removed and replaced date topic from diary record

ae72280

AndreasBrostrom force-pushed the NoDatedDiaryRecord branch from 120f466 to ae72280 Compare June 12, 2019 17:04

commy2 and others added 3 commits June 14, 2019 00:20

fix scripted optics in pause menu in MP (CBATeam#1160)

2c326e2

* draw scripted optic in pause menu in MP * draw scripted optic in pause menu in MP

check masses of items of disposable framework (CBATeam#1161)

20b7c90

Reverted settings

b261892

commy2 approved these changes Jun 14, 2019

View reviewed changes

commy2 added 3 commits June 15, 2019 07:14

update scripted optics effect radblur classes (CBATeam#1163)

0bd78ee

rotate scripted optic according to weapon bank (CBATeam#1162)

cd8a239

* rotate scripted optic according to weapon bank * handle launchers, pistols * update variable names

add cartridge ejection effect on repeat (CBATeam#1158)

6a42995

* add cartridge effect on repeat * optimize * velocity one frame later to fix drawn position in frame 0 * update variable names

654wak654 and others added 18 commits October 3, 2019 18:56

Add missing Turkish Translations

549cc55

Merge pull request CBATeam#1239 from 654wak654/tr-translations

c7079ff

Add Missing Turkish Translations

XEH - Fix version report in rpt

e4042c2

Merge pull request CBATeam#1240 from CBATeam/xehVer

f9f0d02

XEH - Fix version report in rpt

Ignore invalid turrets

f0097f2

Consider [] as driver

b1ef956

Fix whitespace

b74c35d

Co-Authored-By: jonpas <jonpas33@gmail.com>

Add extra param information

7bb6cd1

Merge pull request CBATeam#1237 from neilzar/turret-event

e4a00b3

Add turret event

Statemachine - Trivial performance changes

1032469

Replace all use of count as a forEach

b2829e1

Update fnc_startFallbackLoop.sqf

79fe85b

Merge pull request CBATeam#1242 from CBATeam/trivialSM

855b523

Replace all use of count as a forEach

Scaled cba_optic_big_pip and cba_optic_small_pip models outwards on t…

4c342f6

…he sides to support 21:9 aspect ratio screens.

Adjusted CBA optic camera FOV to 0.78 to account for model changes fo…

25285ef

…r 21:9.

Adjusted CBA optic camera FOV to 1.02 to make the camera match up wit…

78e23c1

…h what you saw before scoping in. See CBATeam#1245 (comment) for comparison of old value.

Changed CBA optic camera FOV back to 0.75 as there is some scaling is…

43f4caa

…sues with increasing this value.

Merge pull request CBATeam#1245 from JonBons/optics-21by9

a2b02af

Add support for 21:9 resolutions to CBA optics addon.

commy2 modified the milestones: Ongoing, 3.13 Oct 29, 2019

commy2 added the Needs Testing label Oct 29, 2019

commy2 changed the title ~~Removed and replaced date topic from diary record~~ localized diary topics Oct 29, 2019

Merge branch 'NoDatedDiaryRecord' of https://github.com/ColdEvul/CBA_A3…

d9f94e7

… into NoDatedDiaryRecord

store diary records in variables

5fe929e

commy2 removed the Needs Testing label Oct 30, 2019

commy2 mentioned this pull request Oct 30, 2019

localized diary topics replacement pull request #1247

Merged

commy2 closed this in #1247 Oct 30, 2019

AndreasBrostrom deleted the NoDatedDiaryRecord branch January 13, 2020 21:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

localized diary topics #1159

localized diary topics #1159

AndreasBrostrom commented Jun 11, 2019

commy2 commented Jun 12, 2019

dedmen commented Jun 12, 2019

dedmen commented Jun 12, 2019

AndreasBrostrom commented Jun 12, 2019

commy2 commented Jun 12, 2019

AndreasBrostrom commented Jun 12, 2019 •

edited

Loading

AndreasBrostrom commented Jun 12, 2019

AndreasBrostrom commented Jun 12, 2019

AndreasBrostrom commented Jun 13, 2019

commy2 commented Jun 13, 2019 •

edited

Loading

AndreasBrostrom commented Jun 13, 2019 •

edited

Loading

commy2 commented Jun 13, 2019

AndreasBrostrom commented Jun 14, 2019 •

edited

Loading

commy2 left a comment

commy2 commented Jun 14, 2019

commy2 commented Oct 30, 2019

commy2 commented Oct 30, 2019

localized diary topics #1159

localized diary topics #1159

Conversation

AndreasBrostrom commented Jun 11, 2019

commy2 commented Jun 12, 2019

dedmen commented Jun 12, 2019

dedmen commented Jun 12, 2019

AndreasBrostrom commented Jun 12, 2019

commy2 commented Jun 12, 2019

AndreasBrostrom commented Jun 12, 2019 • edited Loading

AndreasBrostrom commented Jun 12, 2019

AndreasBrostrom commented Jun 12, 2019

AndreasBrostrom commented Jun 13, 2019

commy2 commented Jun 13, 2019 • edited Loading

AndreasBrostrom commented Jun 13, 2019 • edited Loading

commy2 commented Jun 13, 2019

AndreasBrostrom commented Jun 14, 2019 • edited Loading

commy2 left a comment

Choose a reason for hiding this comment

commy2 commented Jun 14, 2019

commy2 commented Oct 30, 2019

commy2 commented Oct 30, 2019

AndreasBrostrom commented Jun 12, 2019 •

edited

Loading

commy2 commented Jun 13, 2019 •

edited

Loading

AndreasBrostrom commented Jun 13, 2019 •

edited

Loading

AndreasBrostrom commented Jun 14, 2019 •

edited

Loading