Common - improve CBA_fnc_addMagazine and CBA_fnc_addMagazineCargo #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- improve CBA_fnc_addMagazineCargo by allowing the number of rounds to be specified. - improve CBA_fnc_addMagazine by trying to add the magazine to vehicle _unit before throwing it out the window onto the ground, and also pass ammo count to CBA_fnc_addMagazineCargo, so that a partial mag doesn't magically become full
commy2
reviewed
Nov 27, 2021
commy2
reviewed
Nov 27, 2021
- use CBA_fnc_canAddItem only, requires CBATeam#1528
#1528 requires 2.08 commands. But perhaps I am missing something and it can be simplified to use canAdd instead? I am wondering why |
Drofseh
added a commit
to Drofseh/ACE3
that referenced
this pull request
Dec 11, 2021
- add keybind and function to unload unit's weapon/muzzle - requires CBATeam/CBA_A3#1527
2 tasks
PabstMirror
added a commit
to acemod/ACE3
that referenced
this pull request
May 18, 2022
* add keybind and function to unload unit's weapon/muzzle - add keybind and function to unload unit's weapon/muzzle - requires CBATeam/CBA_A3#1527 * change function name * rename the file too * Create common-framework.md * Set REQUIRED_CBA_VERSION to 3.15.7 * Update required CBA version Co-authored-by: PabstMirror <pabstmirror@gmail.com> * Apply suggestions from code review Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: