ProjectileTracking - Stop tracking stationary objects #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bux
reviewed
Sep 15, 2018
|
|
||
| _bulletData pushBack [(getPos _projectile), vectorMagnitude (velocity _projectile)]; | ||
|
|
||
| _data set [1, _bulletData]; |
There was a problem hiding this comment.
did you delete this line intentional?
There was a problem hiding this comment.
{
_bulletData = _data select 1;
} else {
_data = [_handle, _bulletData];
};
_data set [1, _bulletData];
either way _bulletData is going to already be set in _data
bux
reviewed
Sep 15, 2018
|
|
||
| _data set [1, _bulletData]; | ||
|
|
||
| GVAR(projectileData) set [_index, _data]; |
There was a problem hiding this comment.
same here? outside of the if block?
There was a problem hiding this comment.
These are not needed, because only commands that modify the array are used. Previously the function set a sub array, and a sub sub array to exactly what they were before.
commy2
approved these changes
Sep 15, 2018
ViperMaul
added a commit
that referenced
this pull request
Sep 19, 2018
* master: Add Feature Camera Player EH (#982) German brands for JR and JAM components (#988) veteran29 Polish translation updates master (#986) German translation, part 3 (#981) German translation, part 2 (#980) German translation, part 1 (#979) add Joint Ammo Magazines A3 (#928) CBA_fnc_getVolume not calculating volume correctly (#984) ProjectileTracking - Stop tracking stationary objects (#985)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref acemod/ACE3#6565