Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing re enabling file download #15793

Merged
merged 11 commits into from
Sep 9, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
needed to ignore console
  • Loading branch information
etanb committed Sep 6, 2024
commit 2cd29b3d769470ea12a1081d257836046d29cdaf
Original file line number Diff line number Diff line change
@@ -290,7 +290,7 @@
expect(await tableDataCellValue(dailyDataPage.page, 0, 0)).toEqual(reportId);
});

test.skip("returns match for Filename", async ({ dailyDataPage }) => {

Check warning on line 293 in frontend-react/e2e/spec/chromium-only/authenticated/daily-data-page-user-flow.spec.ts

GitHub Actions / Lint

Unexpected use of the `.skip()` annotation
// Filename search is currently broken and being tracked
// in ticket #15644
const fileName = await tableDataCellValue(dailyDataPage.page, 0, 4);
@@ -379,6 +379,7 @@
await context.tracing.start({ screenshots: true, snapshots: true });
await setDate(dailyDataPage.page, "#start-date", 14);
await setDate(dailyDataPage.page, "#end-date", 0);
// eslint-disable-next-line no-console
console.log("HITS TEST: downloads the file");

await applyButton(dailyDataPage.page).click();
@@ -419,9 +420,9 @@
);

if (responsePromise) {
await expect(dailyDataPage.page).toHaveURL(`${URL_REPORT_DETAILS}/${reportId}`);

Check warning on line 423 in frontend-react/e2e/spec/chromium-only/authenticated/daily-data-page-user-flow.spec.ts

GitHub Actions / Lint

Avoid calling `expect` conditionally`
await expect(dailyDataPage.page).toHaveTitle(/Daily Data - ReportStream/);

Check warning on line 424 in frontend-react/e2e/spec/chromium-only/authenticated/daily-data-page-user-flow.spec.ts

GitHub Actions / Lint

Avoid calling `expect` conditionally`
await expect(dailyDataPage.page.locator("h1").getByText(reportId)).toBeVisible();

Check warning on line 425 in frontend-react/e2e/spec/chromium-only/authenticated/daily-data-page-user-flow.spec.ts

GitHub Actions / Lint

Avoid calling `expect` conditionally`

// Facility table headers
await detailsTableHeaders(dailyDataPage.page);
Binary file modified frontend-react/frontend-react/e2e-data/trace-download-test.zip
Binary file not shown.
Loading