Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing re enabling file download #15793

Merged
merged 11 commits into from
Sep 9, 2024
Merged

testing re enabling file download #15793

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a12be52
testing re enabling file download
etanb Sep 5, 2024
7f374d4
add some logging to e2e test run
etanb Sep 5, 2024
5baf50c
increase timeout
etanb Sep 5, 2024
560115f
test uploading trace
etanb Sep 5, 2024
ca42465
slightly cleaner tracing
etanb Sep 6, 2024
89bb6c5
console added
etanb Sep 6, 2024
2cd29b3
needed to ignore console
etanb Sep 6, 2024
c8f9556
test sort method
etanb Sep 6, 2024
626c5f8
simply skip test if mocked
etanb Sep 7, 2024
22ae906
invert truthiness
etanb Sep 7, 2024
805c0ee
Merge branch 'master' into experience/15612/re-re-reenable-file-download
etanb Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions frontend-react/e2e/spec/chromium-only/authenticated/daily-data-page-user-flow.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@
expect(await tableDataCellValue(dailyDataPage.page, 0, 0)).toEqual(reportId);
});

test.skip("returns match for Filename", async ({ dailyDataPage }) => {

Check warning on line 293 in frontend-react/e2e/spec/chromium-only/authenticated/daily-data-page-user-flow.spec.ts

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected use of the `.skip()` annotation
// Filename search is currently broken and being tracked
// in ticket #15644
const fileName = await tableDataCellValue(dailyDataPage.page, 0, 4);
Expand Down Expand Up @@ -373,11 +373,13 @@
await dailyDataPage.page.locator(".usa-table tbody").waitFor({ state: "visible" });
});

test.skip("downloads the file", async ({ dailyDataPage }) => {
await setDate(dailyDataPage.page, "#start-date", 14);
await setDate(dailyDataPage.page, "#end-date", 0);

await applyButton(dailyDataPage.page).click();
test("downloads the file", async ({ dailyDataPage, isMockDisabled }) => {
test.skip(!isMockDisabled, "Mocks are ENABLED, skipping 'downloads the file' test");

Check warning on line 377 in frontend-react/e2e/spec/chromium-only/authenticated/daily-data-page-user-flow.spec.ts

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected use of the `.skip()` annotation
// Sort by File available until, but they're in ASCENDING order
await dailyDataPage.page.getByRole("button", { name: "File available until" }).click();
await dailyDataPage.page.locator(".usa-table tbody").waitFor({ state: "visible" });
// Sort by File available until again, to get the absolute latest result
await dailyDataPage.page.getByRole("button", { name: "File available until" }).click();
await dailyDataPage.page.locator(".usa-table tbody").waitFor({ state: "visible" });

const downloadProm = dailyDataPage.page.waitForEvent("download");
Expand Down Expand Up @@ -414,8 +416,8 @@
);

if (responsePromise) {
await expect(dailyDataPage.page).toHaveURL(`${URL_REPORT_DETAILS}/${reportId}`);

Check warning on line 419 in frontend-react/e2e/spec/chromium-only/authenticated/daily-data-page-user-flow.spec.ts

View workflow job for this annotation

GitHub Actions / Lint 

Avoid calling `expect` conditionally`
await expect(dailyDataPage.page).toHaveTitle(/Daily Data - ReportStream/);

Check warning on line 420 in frontend-react/e2e/spec/chromium-only/authenticated/daily-data-page-user-flow.spec.ts

View workflow job for this annotation

GitHub Actions / Lint 

Avoid calling `expect` conditionally`
await expect(dailyDataPage.page.locator("h1").getByText(reportId)).toBeVisible();

// Facility table headers
Expand Down
Loading