Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the error that caused the side not being scrollable #3415

Merged
merged 102 commits into from
May 4, 2021
Merged

Conversation

fredericbirke
Copy link
Contributor

Fixes the error that caused the side not being scrollable by dragging the scrollbar on chrome within sites that have a sidebar with a toc

@fredericbirke fredericbirke changed the base branch from main to develop April 1, 2021 22:04
@sonarcloud
Copy link

sonarcloud bot commented Apr 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@rstaib rstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's good; Just some minor things I would like to be seen fixed 😸

website/package.json Show resolved Hide resolved
website/src/components/articles/article-sections.tsx Outdated Show resolved Hide resolved
website/src/components/doc-page/doc-page-navigation.tsx Outdated Show resolved Hide resolved
website/src/components/misc/page-top.tsx Outdated Show resolved Hide resolved
@rstaib rstaib merged commit c59403c into develop May 4, 2021
@rstaib rstaib deleted the fb/fixes branch May 4, 2021 15:22
@rstaib rstaib restored the fb/fixes branch May 4, 2021 15:22
rstaib added a commit that referenced this pull request May 4, 2021
Co-authored-by: Frederic Birke <fred@freds.garden>
@rstaib rstaib deleted the fb/fixes branch May 4, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.