Consuming from Water Dispenser doesn't check for fullness #40225
Labels
Fields / Furniture / Terrain / Traps
Objects that are part of the map or its features.
Mechanics: Character / Player
Character / Player mechanics
Quality of Life
QoL: degree to which players are comfortable, and able to enjoy CDDA
<Suggestion / Discussion>
Talk it out before implementing
Describe the bug
If I'm full and I try to drink clean water from any old container, it tells me "You're full already and will be forcing yourself to drink.". With the "new" Water Dispenser, it let's you drink until you puke, which is undesirable.
Steps To Reproduce
Expected behavior
(If I understood the design decision) Drinking and eating anything from any source (including water dispensers) should give you the "your're too full" warning/confirmation, because making the character puke by overconsumption is kinda frustrating (also, in real life you generally know you're about to burst from too much food/drink.)
Versions and configuration
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food]
]
Additional context
I suspect, by shallow code-diving, in consumption.cpp:784, this:
specifically !food.has_infinite_charges() makes the water dispenser bypass generating the warning, but I haven't tried to compile this game from source yet so I can't test it.
An additional related question: Should water dispensers really have infinite charges, aka be an infinite clean water source?
The text was updated successfully, but these errors were encountered: