Replace characters in the Graphical Overmap mod with escape sequences #36535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like the JSON formatter isn't happy with escape sequences. |
ZhilkinSerg
added
[JSON]
Qrox
force-pushed
the
graphical-overmap-escaped-char
branch
from
17d7d82
to
fe47a3b
Compare
This was referenced Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Currently the overmap symbols in the Graphical Overmap mod are written as characters. However, these characters are actually used to draw different symbols, and look like gibberish when viewed in a text editor, making it hard to locate each symbol in the font image. This can be merged once #36538 gets merged.
Describe the solution
Specify the characters using escape sequences, so it's easier to locate the symbol in the font image by looking at the hexadecimal number.
Testing
Tested in game and the symbols are correctly displayed as before. Also used the JSON formatter without #36538 to convert the escape sequences back to characters, and the resulting files were identical to the files before this change.