Make JSON formatter conserve escape sequences #36538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curstwist
added
[C++]
This was referenced Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Build "Made JSON formatter conserve escape sequences"
Purpose of change
Currently the JSON formatter outputs string values by reading from JsonIn and writing to JsonOut, which causes escape sequences in string values to be converted to the respective characters. This is undesirable if the escape sequence is intended to improve readability, for example in #36535.
Describe the solution
Changed the code of the JSON formatter to output string values as written in the input. Also added an option to the CMake list for building the JSON formatter.
Testing
Ran the JSON formatter locally on the changes in #36535 and the escape sequences were correctly conserved.