Added OA-93 pistol and carbine #37561

RarkGrames · 2020-01-30T17:48:18Z

Summary

SUMMARY: Content "Added OA-93 pistol and carbine"

Purpose of change

Adding more compact weapons that use the 5.56mm ammo.

Describe the solution

Added items
Added items to item groups

Describe alternatives you've considered

Adding drop-in auto sear and lightning link mod compatibility, but I have no idea if they would work with these guns.

Testing

Spawned and used the guns
Checked out the item groups with the debug menu

Additional context

Source 1
Source 2

Rarity is based on that there is only a couple of them for sale on gun websites.

I-am-Erk · 2020-01-30T17:50:39Z

Don't forget to update Generic Guns.

ghost · 2020-01-30T22:44:53Z

data/json/items/gun/223.json

+    "type": "GUN",
+    "name": { "str": "OA-93" },
+    "description": "An AR-15 derivative pistol manufactured by Olympic Arms in the nineties. The main difference compared to the AR-15 is that the recoil spring has been moved to the top of the gun, circumventing the necessity for a solid buttstock.",
+    "weight": "2023 g",


Which weight are you using for this?
OA-96 is 4lb3oz/1899g

Second source for the pistol (Length/Weight: 17.00in. / 4.46lbs.).
The first source only states the OA-93 carbine weight.

ghost · 2020-01-30T22:45:39Z

data/json/items/gun/223.json

@@ -325,6 +325,52 @@
    "modes": [ [ "DEFAULT", "semi-auto", 1 ], [ "BURST", "3rd burst", 3 ] ],
    "magazines": [ [ "223", [ "stanag30", "stanag50", "survivor223mag" ] ] ]
  },
+  {
+    "id": "oa93",
+    "copy-from": "rifle_semi",


Need to override the skill used if this is supposed to be a pistol

ghost · 2020-01-30T22:46:43Z

data/json/items/gun/223.json

+    "name": { "str": "OA-93" },
+    "description": "An AR-15 derivative pistol manufactured by Olympic Arms in the nineties. The main difference compared to the AR-15 is that the recoil spring has been moved to the top of the gun, circumventing the necessity for a solid buttstock.",
+    "weight": "2023 g",
+    "volume": "750 ml",


Trying to find the width of an AR15/M16 upper on this for a more accurate for you ATM

ghost · 2020-01-30T22:47:43Z

data/json/items/gun/223.json

+    "name": { "str": "OA-93 carbine" },
+    "description": "An AR-15 derivative carbine manufactured by Olympic Arms in the nineties. The main difference compared to the AR-15 is that the recoil spring has been moved to the top of the gun, circumventing the necessity for a solid buttstock.  This carbine version comes with built-in folding stock and longer barrel.",
+    "weight": "3402 g",
+    "volume": "1750 ml",


Ditto for finding upper's width so I can get you a better volme

Orinyau · 2020-01-30T22:49:21Z

Isn't the lightning link specifically for the AR15, and more specifically AR15s with the older rectangular bolt.

https://www.thefirearmblog.com/blog/2016/06/03/full-auto-on-the-cheap-how-a-lightning-connector-works/

(The part about the bolt is in the comments, confirmed by the author)

I know this PR doesn't add this, but it is something to think about. Also, this source states that there are only 300 lightning links registered, so it seems pretty rare.

And if you consider this a reliable source, it claims that more modifications need to be made due to its length to add full auto capability.
So it doesn't seem that there is any simple drop in full auto conversion.

http://www.imfdb.org/wiki/Olympic_Arms_OA-93

ghost · 2020-01-30T23:30:55Z

Better volume math for the carbine(using the lengths provided by your first source):

https://www.cbcindustries.com/products/complete-ar-15-upper-assembly-16-5-56-x-45-bcg-chh-included-13-cbc-keymod-gen-2-ar-15-handguard-rail-2/
https://www.cbcindustries.com/products/ar-15-upper-assembly-16-5-56x45-1-7-midlength-12-cbc-arms-gen2-keymod-gen-2-ar-15-handguard-rail/

Using their width of 4.5in
Extended volume:
https://www.gunsamerica.com/990106554/Olympic-Arms-Pre-Ban-OA93-Carbine-LNIB.htm
Using this picture for scaling, since it has the stock extended:

120.416 square inches * 4.5in = 541.872in^3 = 8,880 mL

Folded volume:
Using picture from your first source, with stock poking out removed:

113.519 in^2 * 4.5in = 510.8355in^3 = 8.371L

CHONKY GUN 🎉

RarkGrames · 2020-01-30T23:45:02Z

Is this going to be done for every gun? 7 liters is way out of the system of existing gun dimensions in the game. Also, previously I remember you didn't take magazines for measuring.

RarkGrames · 2020-01-30T23:46:18Z

@Orinyau I didn't include the mods because I have no data about compatibility whatsoever. I read somewhere that there were some full auto OA-93 variants, but the manual of the gun I've found was talking about only SA capability. I don't think they mass produced those for civilian market.

ghost · 2020-01-30T23:49:39Z

Is this going to be done for every gun?

Eventually, yes.

7 liters is way out of the system of existing gun dimensions.

Correct, because they're all too small(except for pistols, which are huge, and shotguns since Tonkatsu already audited those).

Also, previously I remember you didn't take magazines for measuring.

Ewps, you're right. Will redo math.

RarkGrames · 2020-01-30T23:57:26Z

Are we supposed to give the volume with the stock folded? Installing a folding stock automatically decreases the volume by 500 ml (?). Is it possible to check the barrel length sticking out of the body? I gave 67 ml for barrel_length, but it is not a very precise number.

ghost · 2020-01-31T00:14:03Z

Fixed the magazine contributing to volume:

Subtract 15.414*4.5in = 1136.656(~1137) ml from both guns.
Carbine, retracted: 7234ml
Carbine, extended: 7743ml

ghost · 2020-01-31T00:31:08Z

Pistol math(w/o the magazine this time I promise 😛):
Using this picture from Olympic Arms' store(one in your source has shadow that would expand the volume):
http://www.olyarms.com/shop/media/catalog/product/cache/1/image/9df78eab33525d08d6e5fb8d27136e95/o/a/oa93.png
Chopped off magazine:

Results(length from your second source used for scaling):

63.323 in^2 * 4.5 in. width(since it's also an AR15-style receiver) = 284.9535 in^3 = 4669.55(~4670)ml

RarkGrames · 2020-01-31T00:43:26Z

uwu

ghost · 2020-01-31T00:56:20Z

I posted a tutorial of how I did this so you can double-check my math over on #37374.

ghost · 2020-01-31T01:02:31Z

data/json/items/gun/223.json

@@ -333,7 +333,7 @@
    "name": { "str": "OA-93" },
    "description": "An AR-15 derivative pistol manufactured by Olympic Arms in the nineties. The main difference compared to the AR-15 is that the recoil spring has been moved to the top of the gun, circumventing the necessity for a solid buttstock.",
    "weight": "2023 g",
-    "volume": "750 ml",
+    "volume": "4383 ml",


See edit, it was 4670ml. I forgot to fill my holes. 😛

tenmillimaster · 2020-01-31T02:53:40Z

The OA93 has long fallen out of popularity. If you're looking for compact 223's, why not just a normal AR pistol? They're far more applicable.

Orinyau · 2020-01-31T07:13:15Z

I don't think it was ever popular. Law enforcement didn't use it long, it was made illegal in '96 spawning some silly variants.

With as rare as it is, it doesn't hurt, but it doesn't fill in any holes either.

RarkGrames · 2020-01-31T12:08:15Z

The OA93 has long fallen out of popularity. If you're looking for compact 223's, why not just a normal AR pistol? They're far more applicable.

To live out hillbilly power fantasies. Also, there are not many ar pistol variants without a buffer tube, so why not add the first one ever made. CDDA is the only game I encountered so far where your survival is directly proportional to the amount of loaded guns strapped to your body to draw, discharge, drop, repeat.

tenmillimaster · 2020-01-31T13:27:00Z

To live out hillbilly power fantasies.

This is practically mod content then. You could add it and make it impossibly super rare, I suppose, but that still overlooks the huge number of 10.5" and 7" barreled AR pistols out there.

RarkGrames · 2020-01-31T14:03:27Z

If you are so unrelenting about it, then I will close it. I don't have must-have on this thing. It just feels a little bit backwards that after adding a sea of marginally useful and obscure guns (which in some cases still have more weight than this one) you disapprove this on the basis of being too rare and having better alternatives.

RarkGrames · 2020-02-06T11:06:30Z

@tenmillimaster If that is fine with you, I can move these to the obscure guns item groups with a really low weight (so the work @laveyanfiend already did is not wasted). If you suggest some similar, but modern gun (small, 5.56, folding stock or stockless) that can be purchased nowadays, then I would implement that also.

tenmillimaster · 2020-02-06T13:28:49Z

To reiterate, I don't have an issue with adding an OA-93, I just think the 7.5" barreled AR's are far, far, far more common. I've gone ahead and done image analysis on one if you'd like to use it.

Based on the same data, I would use the width of receivers below (it's the width from centerline to the midline of the forward assist plunger tube, doubled) instead of 4.5" for your OA-93. 4.5" is a rather extreme size, rail-to rail of a handguard rather than average depth. If you multiply your OA-93's volumes by (2.0568/4.5) you should have your corrected volumes.

Below is the volume data for a typical 7.5" AR pistol.

RarkGrames · 2020-02-06T13:40:14Z

Ok, I can do that. Aside from a custom-built gun, is there any commercial model that uses this exact setup?

tenmillimaster · 2020-02-06T13:45:12Z

Pretty much all of them, though they often come with a "shoulder brace" I thought better implemented as a gunmod.

RarkGrames · 2020-02-06T13:48:55Z

I will make an entry with these stats then with an integrated gunmod on it.

tenmillimaster · 2020-02-06T13:49:29Z

Why would it be integrated and not default?

RarkGrames · 2020-02-06T13:55:12Z

So you can't install a folding or other type of stock on it. Also, what skill these guns require? I have a feeling they are categorized as pistols for legislation purposes, rather than the way they are used.

RarkGrames · 2020-02-06T14:12:42Z

It is not integrated in a strict sense, but per my understanding these shoulder braces can only be used on the buffer tubes of these pistols, and since the tubes prevent the installation of other kind of stocks, making them integrated solves both problems, even though it is a bit of a hacky solution.

tenmillimaster · 2020-02-06T14:15:17Z

Yes, but no other AR-family thing has that same solution currently. I wouldn't bother considering it right now. (Or even bother adding the gunmod.)

RarkGrames · 2020-02-06T14:15:55Z

Ok, then I'll not bother with the gunmod at all.

RarkGrames added 2 commits January 30, 2020 18:35

Added items

e598cd0

Added items to groups

b895a16

I-am-Erk added 0.E Content Freeze [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 30, 2020

RarkGrames added 4 commits January 30, 2020 18:56

Added guns to Generic Guns migration file

4ab136e

Volume tweak

ec855a3

Tweaked spawn weights

1b1d519

Fixed comma

a859afb

ghost reviewed Jan 30, 2020

View reviewed changes

Added pistol skill override

a16c189

Update 223.json

07bd7e8

ghost reviewed Jan 31, 2020

View reviewed changes

Corrected volume

95420ca

RarkGrames closed this Jan 31, 2020

RarkGrames deleted the OA-93 branch January 31, 2020 14:49

weekly-digest bot mentioned this pull request Feb 2, 2020

Weekly Digest (26 January, 2020 - 2 February, 2020) #37641

Closed

ghost mentioned this pull request Feb 5, 2020

Audit holster capacities #37741

Merged

RarkGrames mentioned this pull request Feb 6, 2020

AR pistols #37768

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added OA-93 pistol and carbine #37561

Added OA-93 pistol and carbine #37561

RarkGrames commented Jan 30, 2020

I-am-Erk commented Jan 30, 2020

ghost Jan 30, 2020 •

edited by ghost

Loading

RarkGrames Jan 30, 2020

ghost Jan 30, 2020

ghost Jan 30, 2020 •

edited by ghost

Loading

ghost Jan 30, 2020

Orinyau commented Jan 30, 2020 •

edited

Loading

ghost commented Jan 30, 2020 •

edited by ghost

Loading

RarkGrames commented Jan 30, 2020 •

edited

Loading

RarkGrames commented Jan 30, 2020 •

edited

Loading

ghost commented Jan 30, 2020 •

edited by ghost

Loading

RarkGrames commented Jan 30, 2020 •

edited

Loading

ghost commented Jan 31, 2020

ghost commented Jan 31, 2020 •

edited by ghost

Loading

RarkGrames commented Jan 31, 2020

ghost commented Jan 31, 2020 •

edited by ghost

Loading

ghost Jan 31, 2020 •

edited by ghost

Loading

tenmillimaster commented Jan 31, 2020

Orinyau commented Jan 31, 2020

RarkGrames commented Jan 31, 2020

tenmillimaster commented Jan 31, 2020 •

edited

Loading

RarkGrames commented Jan 31, 2020

RarkGrames commented Feb 6, 2020

tenmillimaster commented Feb 6, 2020

RarkGrames commented Feb 6, 2020

tenmillimaster commented Feb 6, 2020

RarkGrames commented Feb 6, 2020

tenmillimaster commented Feb 6, 2020

RarkGrames commented Feb 6, 2020 •

edited

Loading

RarkGrames commented Feb 6, 2020

tenmillimaster commented Feb 6, 2020 •

edited

Loading

RarkGrames commented Feb 6, 2020 •

edited

Loading

Added OA-93 pistol and carbine #37561

Added OA-93 pistol and carbine #37561

Conversation

RarkGrames commented Jan 30, 2020

Summary

Purpose of change

Describe the solution

Describe alternatives you've considered

Testing

Additional context

I-am-Erk commented Jan 30, 2020

ghost Jan 30, 2020 • edited by ghost Loading

Choose a reason for hiding this comment

RarkGrames Jan 30, 2020

Choose a reason for hiding this comment

ghost Jan 30, 2020

Choose a reason for hiding this comment

ghost Jan 30, 2020 • edited by ghost Loading

Choose a reason for hiding this comment

ghost Jan 30, 2020

Choose a reason for hiding this comment

Orinyau commented Jan 30, 2020 • edited Loading

ghost commented Jan 30, 2020 • edited by ghost Loading

RarkGrames commented Jan 30, 2020 • edited Loading

RarkGrames commented Jan 30, 2020 • edited Loading

ghost commented Jan 30, 2020 • edited by ghost Loading

RarkGrames commented Jan 30, 2020 • edited Loading

ghost commented Jan 31, 2020

ghost commented Jan 31, 2020 • edited by ghost Loading

RarkGrames commented Jan 31, 2020

ghost commented Jan 31, 2020 • edited by ghost Loading

ghost Jan 31, 2020 • edited by ghost Loading

Choose a reason for hiding this comment

tenmillimaster commented Jan 31, 2020

Orinyau commented Jan 31, 2020

RarkGrames commented Jan 31, 2020

tenmillimaster commented Jan 31, 2020 • edited Loading

RarkGrames commented Jan 31, 2020

RarkGrames commented Feb 6, 2020

tenmillimaster commented Feb 6, 2020

RarkGrames commented Feb 6, 2020

tenmillimaster commented Feb 6, 2020

RarkGrames commented Feb 6, 2020

tenmillimaster commented Feb 6, 2020

RarkGrames commented Feb 6, 2020 • edited Loading

RarkGrames commented Feb 6, 2020

tenmillimaster commented Feb 6, 2020 • edited Loading

RarkGrames commented Feb 6, 2020 • edited Loading

ghost Jan 30, 2020 •

edited by ghost

Loading

ghost Jan 30, 2020 •

edited by ghost

Loading

Orinyau commented Jan 30, 2020 •

edited

Loading

ghost commented Jan 30, 2020 •

edited by ghost

Loading

RarkGrames commented Jan 30, 2020 •

edited

Loading

RarkGrames commented Jan 30, 2020 •

edited

Loading

ghost commented Jan 30, 2020 •

edited by ghost

Loading

RarkGrames commented Jan 30, 2020 •

edited

Loading

ghost commented Jan 31, 2020 •

edited by ghost

Loading

ghost commented Jan 31, 2020 •

edited by ghost

Loading

ghost Jan 31, 2020 •

edited by ghost

Loading

tenmillimaster commented Jan 31, 2020 •

edited

Loading

RarkGrames commented Feb 6, 2020 •

edited

Loading

tenmillimaster commented Feb 6, 2020 •

edited

Loading

RarkGrames commented Feb 6, 2020 •

edited

Loading