Audit holster capacities #37741
Merged
Audit holster capacities #37741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only Travis error is the Uberti Cattleman being too big, which is fixed in #37681. 🎉 |
ghost
marked this pull request as ready for review
ZhilkinSerg
added
[JSON]
This was referenced Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "More realistic holster volumes"Purpose of change
Helps #37374, required for #37681.
Describe the solution
Made table of my already merged audits(plus #37374 and #37561), pistols marketed for (sub)compactness or CC highlighted:
Fast draw/deep conceal/ankle holster: Min is derringer/Spectrum rounded down to 100ml, max is the highest of highlighted.
XL Holster: Min based on Skorpion Vz. 61 retracted/if the folding stock didn't exist, Max is Skorpion with Stock rounded up to nearest quarter liter for futureproofing.
Holster, regular: Min based on top 3 of the compact guns, max based on largest non-machine pistol rounded up.
Back holster: Min based on smallest rifle audited so far, max based on largest w/ loaded while rounded up to nearest liter for futureproofing.
Describe alternatives you've considered
Adding Tonkatsu's audit volumes on the LeMat Revolver, shotguns, and Beretta M9A1 to my table as well to decide volumes.
Testing
Loaded ingame. Marking as draft so any professions can have a holster swap before merging.
Additional context
The issue of thinner rifles and thicker handguns fitting in inappropriate holsters should disappear with KorG's holster refactor.
Some guns will indeed not be able to be holstered at all (Remington MCS, for example).