Make Aftershock atomic smartphone a valid music-playing device. #37584
Conversation
Make afs_atomic_smartphone a valid music-playing device.
|
The Wraitheon smartphone could potentially also use MP3 playing. If making play mp3 a flag or some other form of json using instead of a hardcore is within the realm of possibility then that would benefit more than just Aftershock. But if that’s too much to ask no stress. I appreciate what you are doing. |
So should I also add Wraitheon smartphone to the list? Unfortunally, I would be away from my work computer with C++ development setup for a weekend, so I'll do it next week. |
Please add Wraitheon Smartphone to the list. Whenever you get to it is great. :) |
ifreund
added
<Bugfix>
eilaattwood
changed the title
|
I'm done for now, this can be merged. |
This makes mp3 players take the same amount of time to activate or deactivate as music-playing smartphones. PR CleverRaven#37584 added 200 (de-)activation time to the smartphones, but since the mp3 player already had its own 200 move cost, this made the mp3 player take twice as long as the other devices.
* Avoid double activation penalty for mp3 player This makes mp3 players take the same amount of time to activate or deactivate as music-playing smartphones. PR #37584 added 200 (de-)activation time to the smartphones, but since the mp3 player already had its own 200 move cost, this made the mp3 player take twice as long as the other devices. * Mention music instead of earbuds in message Previous message was vague Fixes #37996
Summary
SUMMARY: Bugfixes "Aftershock atomic smartphone not playing music"Purpose of change
Fixes #37420
Describe the solution
Added checks for afs_atomic_smartphone item in iuse::mp3 method
Describe alternatives you've considered
Rework that function to avoid item id hardcoding.
Testing
Created game with aftershock mod, spawned atomic smartphone, smartphone and mp3 player, tried to use all of them.
Created world without Aftershock, spawned mp3 and smartphone, used them.
Additional context
@Maleclypse please comment if I should add something else into that check.