Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix totally broken guns pulled off of turrets yielding intact guns #37620

Merged
merged 2 commits into from
Feb 2, 2020

Conversation

misterprimus
Copy link
Contributor

@misterprimus misterprimus commented Feb 1, 2020

Summary

SUMMARY: Bugfixes "Fix broken gun fixtures on vehicles spawning intact guns when uninstalled"

Purpose of change

To remove exploit that allows guns to be repaired during the removal process. Fixes #37618

Describe the solution

Replaces the "breaks_into" line of the turret.json file with "scrap" instead of [gun]. Now you get scrap metal when you uninstalled a totally smashed gun from a turret, as you should.

Describe alternatives you've considered

Testing

Uninstalled intact, damaged, and destroyed guns from gunship. Result was always as expected.

Additional context

@Brian-Otten
Copy link
Contributor

The one thing that might still need to happen here is make them all break apart into the correct portions of scrap, rather than all of them giving 1-4 scrap metal. If you don't want to do the work for that this could probably be merged and that posted up as a separate issue.

@wapcaplet
Copy link
Contributor

wapcaplet commented Feb 1, 2020

Although they have quite a range of volumes and weights, these guns tend to be fairly large and heavy, ex.:

  • G80 railgun: 2.75 L, 3.91 kg
  • M134D-H minigun: 6.0 L, 19.77 kg
  • M2HB Browning HMG: 5.0 L, 38.0 kg

"Scrap metal" is relatively small and lightweight in-game (0.03 L, 0.05 kg). Even a completely slagged M2HB should give a lot more than 200g of raw metal.

In addition to yielding scrap, it seems appropriate for these broken guns to yield a few possible steel_chunk (0.07 L, 0.25 kg) and/or steel_lump (0.13 L, 1.0 kg) as well.

@misterprimus
Copy link
Contributor Author

misterprimus commented Feb 1, 2020

Although they have quite a range of volumes and weights, these guns tend to be fairly large and heavy, ex.:

  • G80 railgun: 2.75 L, 3.91 kg
  • M134D-H minigun: 6.0 L, 19.77 kg
  • M2HB Browning HMG: 5.0 L, 38.0 kg

"Scrap metal" is relatively small and lightweight in-game (0.03 L, 0.05 kg). Even a completely slagged M2HB should give a lot more than 200g of raw metal.

In addition to yielding scrap, it seems appropriate for these broken guns to yield a few possible steel_chunk (0.07 L, 0.25 kg) and/or steel_lump (0.13 L, 1.0 kg) as well.

True I think I'll throw it into an excel table and make up the parts that way.
scrap_calculator.xlsx
image

@ifreund ifreund added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions labels Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uninstalling destroyed (XX) minigun from gunship yields an intact minigun
5 participants