Delivery Packages (part 1)

[cosmiccoincidence]

Summary

SUMMARY: Content "Adds delivery packages."

Purpose of change

This adds delivery packages of which can be unpacked to reveal random goodies. It's like Christmas any day of the year!

This is a revival of what I started roughly 1.5 years ago and will be split into several parts.

Packages come in 3 sizes like the cardboard boxes. Their contents are based on their size, and you can find the list of items I made before in the link above. But due to the fact I made the package content items groups 1.5 years ago, I may be missing some obvious candidates for package contents that have been added to the game since then. So, if you have any suggestions of additional package contents, let me know and I can add them. 300+ DIFFERENT PACKAGE ITEM GROUPS!!!

Changes in this pr:

• adjusts cardboard box items to work for packages
• adds package items

Additional Context

Changes in following prs:

• add package item groups
• add unpack/disassemble action to packages
• add packages to locations
• add a mail truck
• add 1-2 delivery trucks
• add package distribution center (2x3) and package distribution hub (1x1) locations

[Fris0uman]

You need to lint your changes, you can use this http://dev.narc.ro/cataclysm/format.html

[cosmiccoincidence]

You need to lint your changes, you can use this http://dev.narc.ro/cataclysm/format.html

Yeah, that is what I used. But I did reconfigure some of the short lists at the top of /itemgroups/packages.json as they are easier to read vertically than horizontally. I could revert these if need be...

[AMurkin]

Automated checks disagree with this logic.
So yeah, do what the linter says.

[curstwist]

I've got some boxes I've used in houses and basements, they have general house spawns in them mostly. Be cool to move them into this packaging system eventually. So, I'd suggest household junk boxes, they type of stuff you store and forget about for 20 years, maybe even holiday decorations and such if you want to get fancy.

Their spawn list is in: https://github.com/CleverRaven/Cataclysm-DDA/blob/master/data/json/mapgen_palettes/house_general_palette.json if you want to look. symbol for boxes is "z"

[cosmiccoincidence]

I've got some boxes I've used in houses and basements...

@curstwist I believe I made some item groups of the same fashion somewhere too... We didn't have cardboard boxes at the time so I used crates, and the crates would spawn living room/kitchen/garage/etc stuff depending on what room. They were mostly only used in the 'vacant homes' pack I did which included homes that had garage sales, we're about to move out, just moved in, etc.

I agree it would maybe be nice to consolidate all this into the new system at some point in the future.

[curstwist]

room. They were mostly only used in

ah right, I have seen those. I'll take a look at their groups.

[Little-119]

This is a prime opportunity for a movie reference. Add a Wilson William brand volleyball to the list of possible items

[cosmiccoincidence]

volleyball

There doesn't seem to be one in-game. Though in the future it would be easy to add as well as a park location with a sandy volleyball court.

[I-am-Erk]

This is too much for a single PR. Can you keep the list of packages down a bit, and add more packages in another PR?

It seems to me packages are something that could use the disassembly script like MREs, rather than just appearing in itemgroups

[cosmiccoincidence]

This is too much for a single PR. Can you keep the list of packages down a bit, and add more packages in another PR?

Uhm, I guess. The only thing removing some item groups from this PR would do is lower line count. I admit I had some more item groups ready to push and add to this PR but Ill wait and spread things out more if that's needed.

It seems to me packages are something that could use the disassembly script like MREs, rather than just appearing in itemgroups

I plan to use the 'unpack' being moved to json in #38111 (which the gobag uses)

[cosmiccoincidence]

Broke this PR into more pieces as requested by Erk. This first part I believe is ready.

[kevingranade]

If folding for smaller total volume is a feature of the box, then the box needs to explicitly have that feature, not have contradictory stats.

[cosmiccoincidence]

Closing this until I have time to come back to it.