[Magiclysm] Add Magiclysm academy #38511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new item_groups, 2 maps, magic_basement hint for trap door.
curstwist
added
[JSON]
KorGgenT
reviewed
Mar 2, 2020
KorGgenT
reviewed
Mar 2, 2020
| @@ -662,6 +743,7 @@ | |||
| "type": "GENERIC", | |||
| "copy-from": "spell_scroll", | |||
| "id": "spell_scroll_lava_bomb", | |||
| "//": "Classless spell", | |||
There was a problem hiding this comment.
if lava bomb is classless, that's a mistake, it should be earthshaper.
There was a problem hiding this comment.
not sure how to change that UI display but I changed my note and its new item_group
There was a problem hiding this comment.
oh, maybe the spell itself got missed then
|
sweet. just gotta spawn in a school and check it out; the non map related json changes LGTM |
Co-Authored-By: Curtis Merrill <curtis.r.merrill@gmail.com>
…clysm-DDA into magiclysm-academy
|
i spawned in an academy and i started seeing the class runes. those shouldn't spawn as they are representations of your class that allow you to do certain crafting recipes, as limiting crafting recipes by trait isn't something i wanted to do. |
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 10, 2020
* support files new item_groups, 2 maps, magic_basement hint for trap door. * add magic academy * Update data/mods/Magiclysm/items/books_lore.json Co-Authored-By: Curtis Merrill <curtis.r.merrill@gmail.com> * fix lava bomb * fix typo, improve word choice. * remove rune spanws Co-authored-by: Curtis Merrill <curtis.r.merrill@gmail.com>
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 15, 2020
* support files new item_groups, 2 maps, magic_basement hint for trap door. * add magic academy * Update data/mods/Magiclysm/items/books_lore.json Co-Authored-By: Curtis Merrill <curtis.r.merrill@gmail.com> * fix lava bomb * fix typo, improve word choice. * remove rune spanws Co-authored-by: Curtis Merrill <curtis.r.merrill@gmail.com>
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 15, 2020
* support files new item_groups, 2 maps, magic_basement hint for trap door. * add magic academy * Update data/mods/Magiclysm/items/books_lore.json Co-Authored-By: Curtis Merrill <curtis.r.merrill@gmail.com> * fix lava bomb * fix typo, improve word choice. * remove rune spanws Co-authored-by: Curtis Merrill <curtis.r.merrill@gmail.com>
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 16, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 17, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 17, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 18, 2020
twadams
pushed a commit
to twadams/Cataclysm-DDA
that referenced
this pull request
Mar 24, 2020
twadams
pushed a commit
to twadams/Cataclysm-DDA
that referenced
this pull request
Mar 29, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Mar 29, 2020
twadams
pushed a commit
to twadams/Cataclysm-DDA
that referenced
this pull request
Mar 30, 2020
twadams
pushed a commit
to twadams/Cataclysm-DDA
that referenced
this pull request
Mar 30, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 1, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 1, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 2, 2020
ZhilkinSerg
pushed a commit
that referenced
this pull request
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Mods "Adds new magic academy city building, maps for lairs, retreats."Purpose of change
A common concern hear for magiclysm is how hard it can be to get scrolls for a specific class. This academy aims to lessen that problem, and also offers maps for the harder to find locations.
Also added a photograph hint in the magic basement to improve people's chances of finding the door trigger.
Describe the solution
In adding this academy, I've made loots fairly generous (may need adjustment) and I've set up item_groups for class specific loots (and classless). Each student chamber represents a student specializing in one of the 8 classes and should be a reliable place to find scrolls and occasional books.
The two teacher apartments are more general. There is also an alchemy lab with a good amount of supplies, 2 class rooms and a small library.
I've added 2 maps, one for lairs and one advertising the academy's retreat locations (wizard lake retreat and magic cabins).
Describe alternatives you've considered
Less loot, but I'd like some feed back on how this is for players first.
Right now it has golums and zombie spawns, I may eventually increase the depth and add some monster hunting/training grounds. I need to think about what I want to do and didn't want to sit on this part any longer.
Testing
Spawned in world, tested maps, tested spawns, lots of loot checking.
Additional context
The screenshots:
ground:
basement:
2nd:
3rd
4th
5th
6th
7th
8th
roof:
