Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for confirmation on eating raw meat #39907

Merged
merged 1 commit into from
May 4, 2020

Conversation

RipleyTom
Copy link
Contributor

@RipleyTom RipleyTom commented Apr 25, 2020

Summary

SUMMARY: Interface "Ask for confirmation on eating raw meat"

Purpose of change

Asks for confirmation before eating raw meat.
Before you could accidentally eat raw meat too easily and get parasites.

Describe the solution

We now check if the food has any parasite(which from my quick grep seems to be only raw meat) and asks the user to confirm if he really wants to eat it.

Describe alternatives you've considered

Considered adding a generic flag ASK_EAT but I think checking for parasites is better as it let us have a specific flavor message.

Testing

It now asks if you want to eat a piece of raw meat.
I also altered the test for cannibal eating human flesh to testing with human_cooked as even if you're a cannibal it will warn you about eating raw human flesh(just for health reason instead of moral ones).

Additional context

@curstwist curstwist added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. labels Apr 25, 2020
src/consumption.cpp Outdated Show resolved Hide resolved
src/consumption.cpp Outdated Show resolved Hide resolved
@RipleyTom
Copy link
Contributor Author

Changed the enum name to PARASITES because it's what we're checking but left the message saying it's because it's raw meat as it's still the only food with parasites for now.

Thought about changing the flavor message to "You think you saw something moving in this!" maybe but my guess is you wouldn't be able to see those parasites we have in the game with the naked eye?

@kevingranade kevingranade merged commit 2d5cca7 into CleverRaven:master May 4, 2020
@RipleyTom RipleyTom deleted the confirm_meat branch May 12, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants