Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced price of all lighters to a more reasonable value #39966

Merged

Conversation

TartarusKelvin
Copy link
Contributor

@TartarusKelvin TartarusKelvin commented Apr 27, 2020

Summary

SUMMARY: Balance "Reduced trading prices for both refillable and non refillable lighters"

Purpose of change

Fixes #39945 - Lighters are considerbly more expensive than most other items, a full lighter is worth over $100 while similar fire starting tools are priced closer to $50

Describe the solution

Updated the price and price_postapoc for both lighters

Describe alternatives you've considered

keep the values the same

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with the lighters is that their charges are worth $1.20 each, not the lighter items themselves. You need to fix the charge's worth to fix #39945(you have the wrong issue linked in summary).

data/json/items/tool/fire.json Show resolved Hide resolved
@TartarusKelvin
Copy link
Contributor Author

TartarusKelvin commented Apr 27, 2020

By my understanding of the bartering system what i have done is correct although feel free to correct me:

From Item.cpp more accurately item::price a tool which does not have have ammo which a lighter does not has its value reduced proportional to the number of charges (So if it had a value of 100 but had 5/100 charges it would have a true value of 100 * 5/100) by changing the value to 60 the value of a lighter with 1 charge would actually have a value of 60 * 1/100.

However from npctrade.cpp the value you sell for is changed by 0.05*(Seller Barter Skill - Buyer Barter Skill) which gives $1.20 in the issue.

By my changes the values become:
image

which is the expected values

@Dacendeth
Copy link
Contributor

This is still a lot, with 100 charges a player should be able to sell a lighter for about 10 dollars not factoring any barter bonuses, considering the refillable one is about 5 dollars filled with 50 charges.

@TartarusKelvin
Copy link
Contributor Author

New updated price is $0.10 per charge so a full lighter should sell for $1.00 before barter bonuses

@mlangsdorf mlangsdorf added Items / Item Actions / Item Qualities Items and how they work and interact NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Apr 30, 2020
@mlangsdorf
Copy link
Contributor

$1.2 is probably overvalued but it's not grossly out of whack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items / Item Actions / Item Qualities Items and how they work and interact NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normal lighters have too much trade value.
4 participants