Slipping when climbing down may happen only on unstable terrain below

[Night-Pryanik]

Summary

SUMMARY: Balance "Slipping when climbing down may happen only on unstable terrain below."

Purpose of change

Closes #39892 - Can fall when climbing down a stepladder.

Describe the solution

Added a check for unstable terrain below.

Describe alternatives you've considered

None.

Testing

Climbed up and down on stable terrain (stepladder) and on non-stable terrain (downspouts), also simply jumped down.

Additional context

I hope you're satisfied with this solution @sick-trigger.

[wapcaplet]

From my point of view, this does not really address #39892 - it just changes the odds. Two of the complaints in that issue were:

• The messaging (that it looks easy to climb) is not consistent with the possible outcome (a significant chance of serious injury)
• The risk of descending a ladder (significant chance of falling) is not consistent with the risk of climbing a ladder (no chance of falling)

This change may make it less likely, but these inconsistencies remain.

[Night-Pryanik]

The risk of descending a ladder (significant chance of falling)

The chance to trigger the check for slipping down is 0.1%. If this check triggers, there's another 12.5% check. Total chance is minuscule.

[esotericist]

If there must be a random chance to fail (and I am not even slightly convinced there must be) it should be data attached to the object being interacted with, not a baked-in random chance to the climb down logic.

We've been trying to have less of these in the code, why add more?

[Night-Pryanik]

We've been trying to have less of these in the code

I didn't notice that.

why add more?

Because shit happens, even on firm ground.