Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aftershock] Afs Scraps and the places they spawn #40037

Merged
merged 15 commits into from
Jun 12, 2020

Conversation

Maleclypse
Copy link
Member

Summary

SUMMARY: Mods "Crafting Scraps and spawns"

Purpose of change

This PR aims to add AFS crafting scraps to itemgroups and some nested locations that spawn them.

Describe the solution

Adds to itemgroups and locations. Then appropriate items for the locations.

Describe alternatives you've considered

Not really sure of any

Testing

TBD

Additional context

@Maleclypse
Copy link
Member Author

Just PRing this to make sure it's on my work list. Using existing basement nests as starting points. Need to change names and add notes lines so that nests spawn correctly.

@John-Candlebury John-Candlebury added Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod labels Apr 30, 2020
@Maleclypse
Copy link
Member Author

@curstwist can you recommend the correct name for one of these nested chunks so I can see exactly how it should look and then I can do the rest. Sorry, I'm feeling very unsure after reading this several times.

@curstwist
Copy link
Contributor

curstwist commented May 23, 2020

For the 12x12 rooms:
all of these spawn evenly in relation to each other. I'd assign one of yours to each name, so they don't get duplicate spawn chances so:
recroom_12x12 for resistance_12x12
tvroom_12x12 for cyberpunk_12x12
workoutroom_12x12 for amateur_crispr_12x12

For the 9x9 rooms:
We currently don't have any spawning N/S 9x9 rooms yet. So I recommend reorienting room_6x6_makerspace to East and/or West.

your options for the orchards are:

room_9x9_orchard_N:

  • no 9x9 N spawning yet

room_9x9_orchard_S:

  • no 9x9 S spawning yet

room_9x9_orchard_E:

  • room_9x9_cellar_E (4 spawns),
  • room_9x9_weed_E (3),
  • room_9x9_recroom_E (4)

room_9x9_orchard_W:

  • room_9x9_cellar_W (3),
  • room_9x9_weed _W (3),
  • room_9x9_recroom_W (2)

For your North/South 9x9 orchard rooms, you can still add them and they would get added in when we get some N/S 9x9 nests placed. I can see about fitting them in to one of the unfinished basements soon.

@Maleclypse Maleclypse changed the title WIP [Aftershock] Afs Scraps and the places they spawn [Aftershock] Afs Scraps and the places they spawn Jun 10, 2020
@ZhilkinSerg ZhilkinSerg merged commit fff1f9b into CleverRaven:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants