Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds recipes for bike and motorbike alternators. #40081

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

Tamiore
Copy link
Contributor

@Tamiore Tamiore commented May 2, 2020

Summary

SUMMARY: Content "Adds recipes for bike and motorbike alternators."

Purpose of change

Makes sense in general. If you can craft a motor, why not an alternator?

Describe the solution

Add recipes for alternators. Based on micro and small motor.

Describe alternatives you've considered

Doing nothing.
Adding recipes to craft motors into alternators.

Testing

Works fine locally.

@Rail-Runner
Copy link
Contributor

Rail-Runner commented May 2, 2020

I think you can't really make an alternator as good as a factory-made one that easily.

Not saying you can't make something that would convert mechanical power to electric power at all, but such a makeshift alternator would have to be much less efficient.

@Tamiore
Copy link
Contributor Author

Tamiore commented May 2, 2020

I think you can't really make an alternator as good as a factory-made one that easily.

Technically true, but pretty much no other craftable part for vehicles makes this distinction. Specifically, handmade motors are as good as factory made ones. And an alternator is waaaay easier to make than a motor.

Plus, it's not auto-learned.
And limited for bike and motorbike alternators.

@kevingranade
Copy link
Member

Technically true, but pretty much no other craftable part for vehicles makes this distinction.

Only because we have not gotten around to it. Please make a makeshift alternator if you want it to be craftable.

@Tamiore
Copy link
Contributor Author

Tamiore commented May 4, 2020

Please make a makeshift alternator if you want it to be craftable.

Ok, will do.

However, just to clarify: what's the expected difference between makeshift and normal alternator?
Just lower efficiency, and somewhat larger/heavier?

@curstwist curstwist added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Vehicles Vehicles, parts, mechanics & interactions labels May 4, 2020
@ZhilkinSerg
Copy link
Contributor

Please make a makeshift alternator if you want it to be craftable.

Ok, will do.

However, just to clarify: what's the expected difference between makeshift and normal alternator?
Just lower efficiency, and somewhat larger/heavier?

I guess it should be somewhat bulkier.

@ZhilkinSerg ZhilkinSerg merged commit a7796c3 into CleverRaven:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants