Consume menu fix #40108
Merged
Consume menu fix #40108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
Info / User Interface
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Adjust consume menu code to have same behavior as previous"Purpose of change
The consume menu was cluttered with things you couldn't eat. Additionally, when clearing those out the indentation could confuse users, sothat was disabled for the consume menu.
Describe the solution
First, refactored comestible_inventory_preset slightly to no longer have the special logic to get items in a container, as those items are already populated correctly.
Then, add a new protected member to inventory_selector_preset called _indent that allows one to set constructors of any child class of inventory_selector to disable the indentation.
Note: This also fixes a bug that disallowed you to drink liquids in the consume menu.
Testing
BEFORE:
AFTER: