item inventory ui stacks items #40114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorGgenT
added
Info / User Interface
|
|
|
This closes #40136 as well |
|
i'm having a hard time seeing what test is actually failing with all the !mayfail. so i'm going to try to fix those tests in different PRs and see if that helps? |
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Nested items that are not count_by_charges stack in menus"Purpose of change
Stacking items really reduces the screen space required for something like this:
Fixes #40122
Closes #40136
(the title of that issue isn't really a bug, it fixes the one bug they listed)
Describe the solution
when adding an item to an inventory_column, if the item is a contained item and it shares a parent with another item in the inventory column, the entry in that column is added to instead of adding a new entry.
Testing
Additionally, made sure the multidrop menu works properly.