Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crafting iteminfo test #40123

Merged

Conversation

kevingranade
Copy link
Member

Summary

SUMMARY: None

Purpose of change

I noticed that this crafting based iteminfo test was flaking out sometimes because the player had the recipe memorized.
Upon clearing the player known recipes I discovered that the book-based test has always been a false positive.

Describe the solution

Clear the player known recipes and then jump through he hoops necessary to have the book in the player inventory appear in the crafting inventory.

Testing

Test the test with testing.

@ifreund ifreund added [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels May 4, 2020
@ZhilkinSerg ZhilkinSerg merged commit 7ba9c31 into CleverRaven:master May 4, 2020
@kevingranade kevingranade deleted the fix-iteminfo-crafting-test branch June 28, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants