Improve itype layout #40162
Merged
Improve itype layout #40162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One side-effect of the nested containers change was that clang-tidy started reporting about excessive padding in itype. The check was temporarily disabled because we didn't want additional churn in that PR. This re-enables that check and rearranges the fields in itype. Mostly just moving all the public members to the start of the class, which allows two bool members to be adjacent where they previously weren't. That ought to be enough to reduce the padding sufficiently. I wasn't able to reproduce the padding check failure locally even before this change. Not sure why, but this change seems like an improvement regardless.
KorGgenT
added
[C++]
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
One side-effect of the nested containers change was that clang-tidy started reporting about excessive padding in
itype. The check was temporarily disabled because we didn't want additional churn in that PR. Now we want to re-enable it.Describe the solution
Re-enable that check and rearrange the fields in
itype. Mostly just moving all the public members to the start of the class, which allows twoboolmembers to be adjacent where they previously weren't. That ought to be enough to reduce the padding sufficiently.Describe alternatives you've considered
A more dramatic re-ordering.
Testing
I wasn't able to reproduce the padding check failure locally even before this change. Not sure why, but this change seems like an improvement regardless.
Be sure to check the clang-tidy CI check before merging.