Finish making consume take time

[Ramza13]

Summary

SUMMARY: Features "Finish making consume take time"

Purpose of change

Fixes #36972
Add rest of features to consumption taking time.

Describe the solution

Mutations can now alter eat/drink speeds and I moved the existing mutation based eat time logic into json. The consume menu now shows consume time. Drug's and medicine have had their consume times broken out. To fix auto eat/drink I made them simply instant.

Describe alternatives you've considered

The linked PR suggested showing percentages of completion but someone else is doing a generic solution for that so I left it undone. The drug/medicine times are what sounded good to me and I welcome suggestions to tweak them. Making auto eat/drink take time as well but the prospect of pausing the current activity to start another and then resume didn't seem worth it considering consume times are tiny compared to the crafting time.

Testing

Additional context

[rsulli55]

Because #40126 was recently merged, if you want this activity to be resumable you will need to add an override toactivity_actor::can_resume_with_internal .

[Ramza13]

Because #40126 was recently merged, if you want this activity to be resumable you will need to add an override toactivity_actor::can_resume_with_internal .

That's probably a good idea but after my previous git misadventures I'm going to wait until this is merged first.

[rsulli55]

Because #40126 was recently merged, if you want this activity to be resumable you will need to add an override toactivity_actor::can_resume_with_internal .

That's probably a good idea but after my previous git misadventures I'm going to wait until this is merged first.

Sounds good, being newish to git myself I definitely understand that.

[kevingranade]

I don't know how, but this breaks some crafting tests.

[anothersimulacrum]

Could you change that Finishes to Fixes so that issue is automatically closed when this PR is merged?

[Ramza13]

Ok tests should be fixed and I added in the can_resume_with_internal override