Compact aim window pt.2 - Numbers

[Kilvoctu]

Summary

SUMMARY: Interface "Compact aim window pt.2 - Numbers"

Purpose of change

Part 2 of #37715 in which the aim window automatically decreases in width (from 55 to 34) when using "compact" and "labels-narrow" sidebars. This part handles the "Numbers" accuracy display style.

Describe the solution

Remake the "Numbers" accuracy display style to better fit into the narrow aim window. Aim confidence, percentages and moves are displayed as a table. A new function insert_table is created to handle this display.

Describe alternatives you've considered

None.

Testing

Compile and launch game
Test aiming on an NPC and an enemy using bars and numbers accuracy display, with narrow and standard sidebar width. Tested on maximized and minimal terminal size.

Additional context

Below is a comparison of how the "Numbers" display looks normally, then how it looks under a narrow sidebar style.

[Kilvoctu]

Seems like I didn't need to change much from my initial commit. After all, this project was effectively completed months ago and was just waiting for pt 1 to be merged.

I've noticed that under a narrow sidebar style, the accuracy display stays near the middle and doesn't adjust depending on whether there's a target or not. Like so:

Normally, when no target is highlighted, these four blank spaces are absent, leaving no gap between "Recoil" and "Steadiness".
As this behavior exists in current builds, idunno if it's a stylistic choice since the compact aim window provides so much vertical space that we can dedicate four rows to a possible target. Not sure if I should leave it as is or restore the default behavior.

Sidenote, as can be seen from above screenshot, the legend below "Steadiness" is centered now. I think it looks better. As per a past suggestion, this legend is a single long string, to help ease translations.

Not sure what else to add, so opening the PR for review now.

[olanti-p]

I've noticed that under a narrow sidebar style, the accuracy
display stays near the middle and doesn't adjust depending on
whether there's a target or not. Like so:

This is a new behavior for almost all layouts, you can check function panel_target_info for how it works. The space for target always takes 4 lines to prevent whatever print_ranged_chance prints from jumping around - in this case, the table. Saves the effort of searching for a necessary row each time you move the cursor.

[ifreund]

Thanks!

[Kilvoctu]

Thanks for the explanation @olanti-p. It took me by surprise seeing this new behavior, as I've been away for awhile. I like the bool fill_with_blank_if_no_target in the mention function

And thanks again @ifreund (and everyone else) for all your support on this project :)