bugfix_line_spell: prevent narrow line spells from being stopped early #40242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line attack spells with narrow AOE (0 or 1) were being prevented from actually working as intended. The exception added to the condition prevents exiting early if the spell is a line attack.
KorGgenT
added
<Bugfix>
Splits spell effect area calculation out of `spell_effect_area` to allow independent testing without calling the drawing function `explosion_handler::draw_custom_explosion`
spell_type factory is not empty prior to running this test, clearing it messes up other tests.
ZhilkinSerg
reviewed
May 9, 2020
following convention across headers in repo Co-authored-by: ZhilkinSerg <ZhilkinSerg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix Narrow Line Spell Effects"Purpose of change
Line attack spells with narrow AOE (0 or 1) were being prevented from
actually working as intended. The exception added to the condition
prevents exiting early if the spell is a line attack.
Fixes #39955
Describe the solution
Add an exception for line spells to
spell_effect_areawhich generates the final list of points to have damage applied.Testing
In the referenced issue spells such as
mana beamandlightning boltwould at most produce a single sound, and damage a single monster. With the exception applied the same spells were able to damage all zombies covered by the targeting UI.