Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove melee_train() duplicate #40283

Conversation

CodeBandit
Copy link
Contributor

Summary

SUMMARY: bugfixes "Remove duplicate melee_train() call"

Purpose of change

Remove a duplicate melee_train() call

Describe the solution

This is being called when just a few lines down, the picture after it is being called as well.
image

image

Describe alternatives you've considered

not removing it

Testing

no compilation errors

Additional context

Additional things it affects:
Focus drain will not drain as quickly for melee combat (actually a buff?) so there could be more exp for melee for levels 1 to 5.

Focus drain becomes consistent. Previously, it was faster from levels 1 to 5 than it was 6 to 10. This was inconsistent with how every other skill trained.

Copy link
Member

@anothersimulacrum anothersimulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a duplicate. The one removed is only called if hit_spread < 0 (a miss), the other one is only called if hit_spread >= 0 (a hit).

@CodeBandit
Copy link
Contributor Author

This is not a duplicate. The one removed is only called if hit_spread < 0 (a miss), the other one is only called if hit_spread >= 0 (a hit).

wow yikes, i can't believe I missed that. Closing the PR

@CodeBandit CodeBandit closed this May 7, 2020
@CodeBandit CodeBandit deleted the Remove-weird-melee_train()-duplicate branch May 7, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants