Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gorging penalties #40284

Merged
merged 9 commits into from
May 18, 2020
Merged

Gorging penalties #40284

merged 9 commits into from
May 18, 2020

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented May 7, 2020

Summary

SUMMARY: Features "Add penalties for gorging and json control of hunger penalties."

Purpose of change

Fixes #36973
Adds penalties for over eating and now all levels of hunger have an effect that can be edited to change hunger penalties

Describe the solution

Added new effects for all hunger levels, all but full and engorged have no effect at present. Moved code that handled what your hunger level is out of display code and into update stomach. Modified coloring and names of hunger statuses slightly.

Describe alternatives you've considered

Combining the code in update stomach that sets hunger with the hunger level code to make the display lag a bit like stomach contents. Hard coding rather than using json.

Testing

Additional context

@KorGgenT
Copy link
Member

KorGgenT commented May 7, 2020

i only glanced at this, but is there any way you can improve this to not use an if-else ladder? it's huge

@Dacendeth
Copy link
Contributor

Does this mean i'll vomit even with the gourmand trait when full, that traits supposed to prevent that sorta thing.

@mlangsdorf mlangsdorf added Items: Food / Vitamins Comestibles and drinks Mechanics: Character / Player Character / Player mechanics labels May 7, 2020
@Ramza13
Copy link
Contributor Author

Ramza13 commented May 8, 2020

Does this mean i'll vomit even with the gourmand trait when full, that traits supposed to prevent that sorta thing.

Looking at the code gourmand increases your stomach capacity, meaning you can eat more. This PR won't change that at all, you can still eat more before suffering consequences.

@kevingranade kevingranade merged commit 3e49b53 into CleverRaven:master May 18, 2020
@Ramza13 Ramza13 deleted the gouging branch May 18, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items: Food / Vitamins Comestibles and drinks Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Penalties for gorging
5 participants