Replace hardcoded water terrain checks with flags #40304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
force-pushed
the
waterloo
branch
from
8b48536 to
3a745f1
Compare
ZhilkinSerg
added
[C++]
anothersimulacrum
force-pushed
the
waterloo
branch
from
3a745f1 to
d1bcdf7
Compare
This should expand coverage and make sure that all shallow and deep water types are appropriately used.
anothersimulacrum
force-pushed
the
waterloo
branch
from
0ece751 to
0768933
Compare
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
This should expand coverage and make sure that all shallow and deep water types are appropriately used.
Besides, hardcoding specific terrains is bad.
Describe the solution
Replace checks for specific water terrains with check for terrain flags.
Added shallow water terrain flag.
Documented terrain flag, and added it to all appropriate terrains.
Describe alternatives you've considered
Leaving hardcoded terrain checks in?
Testing
Teleport under a river and attempt to mine a stair up. Receive a message about there being water above.
Open advanced inventory, and set one of the panes to be over water. See that it shows
WATERin the pane.I am not set up to test sounds, but to do so, enable a soundpack and walk through water.