Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit pine nuts and remove the recipe #40305

Merged
merged 3 commits into from
May 8, 2020

Conversation

CodeBandit
Copy link
Contributor

@CodeBandit CodeBandit commented May 7, 2020

Summary

SUMMARY: Balance "Audit Pine Nuts"

Purpose of change

Audit pine nuts to realistic caloric density etc. and remove the pine nut recipe.

Describe the solution

Change JSON values to half of what they were since the calories listed would be approximately double of what it would be per pinecone.

Pinecones have 2 nuts per scale with approximately 50 scales per average pinecone.
That's about 100 nuts, which would weigh about 15 grams.
Additionally, 10 nuts are about 11 calories, thus leading to 110. But, not all the nuts are going to be good so 101 (exactly half of current values) is a reliable estimate.

Additionally, the type of pine nuts used for consumption in the game are not true to new england since they are not harvestable in new england.

Describe alternatives you've considered

Continue to let the pine king rule.

Testing

Spawn pine nuts.
image

@kevingranade
Copy link
Member

Just FYI, the pine nuts this is based on aren't even present in New England, they should be replaced with foods it's reasonable to forage for in New England.

@CodeBandit
Copy link
Contributor Author

Should pine nuts be removed from the game since they aren't technically harvestable in new england?

@mrkybe
Copy link
Contributor

mrkybe commented May 7, 2020

Should pine nuts be removed from the game since they aren't technically harvestable in new england?

I believe there might be stores that sell a variety of foods not typically harvestable in New England. ;)

If they aren't already, maybe add them to grocery stores/gas station snack things?

@dissociativity
Copy link
Contributor

dissociativity commented May 8, 2020

I'd make them take significantly longer to harvest from pinecones given they'd be smaller nuts, time for pine nuts and/or resources needed for a handful with this merged is still the remaining issue, it's too quick and efficient still to harvest, perhaps make the recipe require two or more pinecones for one handful?

Pine nuts technically exist in any pinecones, the practicality of havesting a handful varies wildly depending on species.

@CodeBandit
Copy link
Contributor Author

For now, I have opted to obsolete the pine nut recipe from pinecones and increase their spawn probabilities in item groups already containing pine nuts.

@BenlyAZ
Copy link

BenlyAZ commented May 8, 2020

New England pine trees do have edible seeds, they're just smaller than the pine nuts from European stone pines. They are, however, seasonal as the seeds drop out of the cone eventually. For an overview of wild-harvesting pine nuts for American survivalists, primalsurvivor.net/harvest-pine-nuts-wild/ seems like a good start.

@CodeBandit
Copy link
Contributor Author

CodeBandit commented May 8, 2020

Well okay, I didn't mean to dive this deep into it, but to really shut this down, here it is:
https://www.maine.gov/dacf/mfs/publications/handbooks_guides/forest_trees/pdf/Pines.pdf

There is no distinction between the species of pine trees in CDDA. From the link above there are species of pine trees in the pine tree state (maine) which comprise about 50% of new england.
image

Of those 5 trees, 3 of them are prevalent in all of new england, their partial distribution maps are as follows:
Pinus Rigida
image

Pinus Strobus
image

Pinus Resinosa
image

This is also directly backed up by the game's description of pine trees:
image

Only one of these seeds (in particular the Pinus Strobus) was used for consumption historically, however not mainly for the nut itself.

Source
[Eastern White pine has very small nuts, they can be eaten, but usually are too much effort to collect.]

With that, I personally believe pine nuts shouldn't be craftable from pinecones.

With the removal of the pine nut recipe (if merged) I may look into foraging in a different PR.

@CodeBandit CodeBandit changed the title Audit pine nuts Audit pine nuts and remove the recipe May 8, 2020
@kevingranade kevingranade merged commit 730d5fa into CleverRaven:master May 8, 2020
@CodeBandit CodeBandit deleted the Audit-pine-nuts branch May 9, 2020 18:15
@EvgenijM86
Copy link
Contributor

More on the topic of overpowered food sources: I was doing a winter start game, found diary farm, brought cows inside a house and tied them with a rope, and then simply lived there for over a month. 2 cows generate enough milk to always to max out your quench needs even with High Thirst trait. And it seems that you can sustain yourself that way without needing to collect any other food source ever again, as long as cows are safe.

image

tung pushed a commit to tung/Cataclysm-DDA that referenced this pull request Jul 27, 2020
* Obsolete pine nut recipe and enhance pine nut spawns

(cherry picked from commit 730d5fa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants