Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework herbivore mutation chain #40351

Merged
merged 1 commit into from
May 11, 2020

Conversation

enaantd
Copy link
Contributor

@enaantd enaantd commented May 8, 2020

Summary

SUMMARY: Content "rework the herbivore mutation chain"

Purpose of change

Several things related to the herbivore chain need adjustment in my opinion:

  • Meat intolerance and Herbivore are not related, thus making it possible to have these two traits at the same time,
  • Some meat-related traits are not in conflict with the herbivore traits,
  • Herbivore traits are exclusive to Saprovore trait, even though feeding on dead plant tissue is a thing,
  • Meat intolerance is exclusive to Hates fruits and Hates vegetables, which is incorrect in my opinion.

Describe the solution

  • Meat intolerance is now a prerequisite for Herbivore,
  • Cannibal, Eater of the Dead, Strict Humanitarian and Sapiovore are now exclusive to Herbivore traits,
  • Herbivore and Saprovore traits are not exclusive anymore.
  • Meat intolerance is not exclusive to Hates fruits and Hates vegetables anymore. Herbivore, Ruminant and Grazer still are.

Describe alternatives you've considered

None, any feedback is appreciated though.

Testing

I created a character with the Cannibal and Strict Humanitarian traits, and made them go through the Cattle mutation chain. They lost both traits when gaining Meat intolerance, which then turned into Herbivore and the like.

Additional context

It's my first time meddling with mutation chains, I do not know if the exclusions transfer to further mutations. I made all trait conflicts explicit, but I can change it in case it's not needed.

I also change the id for Hates vegetables from MEATARIAN to ANTIVEGGY in order to better reflect what this trait is really about.
reverted that change for compatibility reasons.

@curstwist curstwist added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels May 8, 2020
@enaantd enaantd force-pushed the herbivore-chain branch from 69f50ee to 3aa3de3 Compare May 8, 2020 17:14
@enaantd enaantd requested a review from John-Candlebury as a code owner May 8, 2020 22:33
@Termineitor244
Copy link
Contributor

I also change the id for Hates vegetables from MEATARIAN to ANTIVEGGY in order to better reflect what this trait is really about.

Oh, it would be better if you didn't, I think that would break old saves with this trait (As the trait will no longer exist, the characters will now be able to eat vegetables when they previously didn't), some traits have IDs that are no longer representative of their actual effects, but that stay that way for save compatibility, at least.

See this example with the ID trait for "Scout":

"id": "EAGLEEYED",
"//": "Can't change the ID as that breaks save-compatibility.",

That´s what it says...
Of course, you can ignore save compatibility, but I think it will be better if you don´t? But well, losing a bad trait is way better that suddenly losing the good trait of "Scout"...

@enaantd enaantd force-pushed the herbivore-chain branch from f9ca84c to 0ea651f Compare May 9, 2020 11:12
@enaantd
Copy link
Contributor Author

enaantd commented May 9, 2020

I reverted the change.

@Rivet-the-Zombie Rivet-the-Zombie merged commit 2f17c6c into CleverRaven:master May 11, 2020
@enaantd enaantd deleted the herbivore-chain branch May 13, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants