Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "rework the herbivore mutation chain"
Purpose of change
Several things related to the herbivore chain need adjustment in my opinion:
Meat intolerance
andHerbivore
are not related, thus making it possible to have these two traits at the same time,Saprovore
trait, even though feeding on dead plant tissue is a thing,Meat intolerance
is exclusive toHates fruits
andHates vegetables
, which is incorrect in my opinion.Describe the solution
Meat intolerance
is now a prerequisite forHerbivore
,Cannibal
,Eater of the Dead
,Strict Humanitarian
andSapiovore
are now exclusive to Herbivore traits,Saprovore
traits are not exclusive anymore.Meat intolerance
is not exclusive toHates fruits
andHates vegetables
anymore.Herbivore
,Ruminant
andGrazer
still are.Describe alternatives you've considered
None, any feedback is appreciated though.
Testing
I created a character with the
Cannibal
andStrict Humanitarian
traits, and made them go through the Cattle mutation chain. They lost both traits when gainingMeat intolerance
, which then turned intoHerbivore
and the like.Additional context
It's my first time meddling with mutation chains, I do not know if the exclusions transfer to further mutations. I made all trait conflicts explicit, but I can change it in case it's not needed.
I also change the id forHates vegetables
fromMEATARIAN
toANTIVEGGY
in order to better reflect what this trait is really about.reverted that change for compatibility reasons.