Change clothing shop cart generation to be inside the store #51178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes carts check for in-store generation instead of on the grass outside.
Made minor adjustments to locations of plants and mannequins (and a wall) to prevent carts from generating in weird obstructed corners. I may just revert all this and switch to defined zone generation instead. Thinking...
|
I don't like those carts generating in the northwest and especially the northeast corners. |
actual-nh
added
<Bugfix>
Venera3
pushed a commit
to Venera3/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2021
…ven#51178) Makes carts check for in-store generation instead of on the grass outside. Made minor adjustments to locations of plants and mannequins (and a wall) to prevent carts from generating in weird obstructed corners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix for mis-generated cart locations in clothing shop map"
Purpose of change
Fixes #51175
Changes target terrain with mis-generated cart locations to have the carts generate in the correct places. Makes carts check for in-store generation instead of on the grass outside.
Describe the solution
Change the ASCII character potential cart generation is assigned to from a
"."to" "Describe alternatives you've considered
Changing to defined zone method other maps used. Doesn't give significant advantages (discussed in issue #51175).
Testing
Changed it locally and spawned a new shop with carts at 100%. Every potential spawn location correctly filled:
