Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollable #51909

Merged
merged 5 commits into from
Oct 4, 2021
Merged

Scrollable #51909

merged 5 commits into from
Oct 4, 2021

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Sep 26, 2021

Summary

None

Purpose of change

Fix #51763
Improve display of popup messages from dialog effects

Describe the solution

Describe alternatives you've considered

Testing

Used json

,
  {
    "id": "EOC_TEST",
    "type": "effect_on_condition",
    "recurrence_min": 1,
    "recurrence_max": 1,
    "global":true,
    "effect": [ { "u_message": " <color_light_green>new</color><header>:mutation\n scroll <bold>bold</bold> testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll testscroll test", "popup":true  },
      { "u_message": "<color_light_red>new</color><color_white>", "popup":true }]
  }

Additional context

@Maleclypse Maleclypse added [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Effects / Skills / Stats Effects / Skills / Stats labels Sep 26, 2021
src/npctalk.cpp Show resolved Hide resolved
@Ramza13 Ramza13 force-pushed the scrollable branch 10 times, most recently from 3349c9f to a2c5b4b Compare October 1, 2021 20:56
@ZhilkinSerg ZhilkinSerg merged commit 17a7ee3 into CleverRaven:master Oct 4, 2021
@Ramza13 Ramza13 deleted the scrollable branch October 4, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Effects / Skills / Stats Effects / Skills / Stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scrolling, formatting to dialog popups
4 participants