Allow talking to pets #52030
Merged
Allow talking to pets #52030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
the
[C++]
|
So would this allow me to yell a sentence containing my pet's name to have it come to me? |
Nope |
|
Interesting feature, but it seems to crash on TALK_DONE. |
Ha so just tested this and I'm getting a crash on starting the conversation not TALK_DONE. That said by chance my PR #52717 should fix the crash I am seeing and hopefully the issue you are having as well. |
So can you still cause a crash on TALK_DONE with the latest experimental? If so I'd love some details to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
none
Purpose of change
Handle second part of #51992
Allow talking to pet
Describe the solution
Describe alternatives you've considered
Doing the first part of #51992 as well. Turns out its a lot harder than this was.
Testing
Added this line to mon_cat in json and then started a cat dude.
Additional context