Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Tacoma to rotate #57548

Merged
merged 1 commit into from
May 11, 2022
Merged

Allow Tacoma to rotate #57548

merged 1 commit into from
May 11, 2022

Conversation

haveric
Copy link
Contributor

@haveric haveric commented May 8, 2022

Summary

None

Purpose of change

Fixes #33525

Describe the solution

Now that all of the PRs are merged in for Tacoma rotation fixes, we can turn on rotation again.

Describe alternatives you've considered

None

Testing

I've been working with a rotated map the whole time for my Tacoma PRs to make sure everything is built correctly.

Additional context

It's finally happening!!!

Probably should wait until #57481 gets merged, but it's not technically required.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 8, 2022
@haveric haveric mentioned this pull request May 8, 2022
71 tasks
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 8, 2022
@dseguin dseguin merged commit 1bb7463 into CleverRaven:master May 11, 2022
@haveric haveric deleted the tacoma-rotate branch May 11, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tacoma Commune faction missions are still hard-coded and require an unrotated map
2 participants