Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add postprocess bam and memory to vardict #1332

Merged
merged 19 commits into from
Nov 28, 2023

Conversation

mathiasbio
Copy link
Collaborator

@mathiasbio mathiasbio commented Nov 27, 2023

This PR:

This PR aims to solve the issue in VarDict randomly crashing with the mysterious memory issue: #1286

Tests:

  • It has been run 12 times on the same TGA T/N case that usually fails 1 out of 6 times, and succeeded in all attempts.
  • downsampled WGS T/N case runs without errors
  • TGA T/N umi case runs without errors

Added:

  • Picard AddReadGroup command before VarDict
  • Samtools sort and index after merging reads with Sentieon Dedup

Changed: for changes in existing functionality.

  • Increased memory and threads for VarDict

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a08f380) 99.43% compared to head (7b912c7) 99.43%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release_v13.0.0    #1332   +/-   ##
================================================
  Coverage            99.43%   99.43%           
================================================
  Files                   38       38           
  Lines                 1962     1962           
================================================
  Hits                  1951     1951           
  Misses                  11       11           
Flag Coverage Δ
unittests 99.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathiasbio mathiasbio changed the title Add memory to vardict add postprocess bam and memory to vardict Nov 28, 2023
@mathiasbio mathiasbio changed the title add postprocess bam and memory to vardict fix: add postprocess bam and memory to vardict Nov 28, 2023
@mathiasbio mathiasbio self-assigned this Nov 28, 2023
@mathiasbio mathiasbio added this to the Release 13 milestone Nov 28, 2023
@mathiasbio mathiasbio marked this pull request as ready for review November 28, 2023 09:54
@mathiasbio mathiasbio requested a review from a team as a code owner November 28, 2023 09:54
@fevac
Copy link
Contributor

fevac commented Nov 28, 2023

@mathiasbio this is really great. As far as I can see, this PR:

  • Increases memory for Vardict
  • Filter bam files by only keeping mapped reads
  • Changes readgroup in bam files

I guess you don't know what is actually solving the issue?

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mathiasbio
Copy link
Collaborator Author

All tests succeed! So I will squash and merge this 🌟

@mathiasbio mathiasbio merged commit d9c0510 into release_v13.0.0 Nov 28, 2023
8 checks passed
@mathiasbio mathiasbio deleted the add_memory_to_vardict branch November 28, 2023 19:20
@mathiasbio
Copy link
Collaborator Author

And yes! Exactly, I still don't know why it's happening or why this seems to have solved the issue 😬

@ivadym ivadym mentioned this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

3 participants