-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add postprocess bam and memory to vardict #1332
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release_v13.0.0 #1332 +/- ##
================================================
Coverage 99.43% 99.43%
================================================
Files 38 38
Lines 1962 1962
================================================
Hits 1951 1951
Misses 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@mathiasbio this is really great. As far as I can see, this PR:
I guess you don't know what is actually solving the issue? |
…BALSAMIC into add_memory_to_vardict
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
All tests succeed! So I will squash and merge this 🌟 |
And yes! Exactly, I still don't know why it's happening or why this seems to have solved the issue 😬 |
This PR:
This PR aims to solve the issue in VarDict randomly crashing with the mysterious memory issue: #1286
Tests:
Added:
Changed: for changes in existing functionality.
Review and tests: