Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update QC criteria #952

Merged
merged 27 commits into from
Jun 17, 2022
Merged

refactor: Update QC criteria #952

merged 27 commits into from
Jun 17, 2022

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Jun 10, 2022

This PR:

Updates QC criteria for panel and wgs analysis.
Removes outdated balsamic report files (balsamic_report.html & balsamic_report.md).

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@ivadym ivadym linked an issue Jun 10, 2022 that may be closed by this pull request
7 tasks
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #952 (9937b1c) into develop (d202a40) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #952   +/-   ##
========================================
  Coverage    99.24%   99.24%           
========================================
  Files           28       29    +1     
  Lines         1713     1714    +1     
========================================
+ Hits          1700     1701    +1     
  Misses          13       13           
Flag Coverage Δ
unittests 99.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
BALSAMIC/constants/qc_metrics.py 100.00% <ø> (ø)
BALSAMIC/utils/cli.py 99.69% <ø> (-0.02%) ⬇️
BALSAMIC/commands/init/base.py 100.00% <100.00%> (ø)
BALSAMIC/commands/report/deliver.py 100.00% <100.00%> (ø)
BALSAMIC/utils/io.py 100.00% <100.00%> (ø)
BALSAMIC/utils/rule.py 94.21% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d202a40...9937b1c. Read the comment docs.

@ivadym ivadym marked this pull request as ready for review June 16, 2022 15:49
@ashwini06 ashwini06 requested a review from keyvanelhami June 16, 2022 16:11
@ivadym
Copy link
Contributor Author

ivadym commented Jun 17, 2022

Tested metric extraction for TN WGS case (different conditions for tumor & normal samples):

ACC6307A1: normal sample
ACC5821A7: tumor sample

Screen Shot 2022-06-17 at 09 43 43

Screen Shot 2022-06-17 at 09 44 57

Screen Shot 2022-06-17 at 09 54 35

Copy link
Contributor

@keyvanelhami keyvanelhami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Vadym, I have some few comments

@keyvanelhami
Copy link
Contributor

@ivadym Let me know when ready and I will merge the PR

@ivadym
Copy link
Contributor Author

ivadym commented Jun 17, 2022

I think we still need approval from @ashwini06 and/or @khurrammaqbool as code owners. Maybe they can also come up with some ideas, suggestions on the implementation of this.

Copy link
Contributor

@ashwini06 ashwini06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

BALSAMIC/commands/init/base.py Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ivadym ivadym merged commit ee956cd into develop Jun 17, 2022
@ivadym ivadym deleted the update-qc-criteria branch June 17, 2022 15:52
@ashwini06 ashwini06 mentioned this pull request Jun 21, 2022
3 tasks
@ivadym ivadym mentioned this pull request Jul 6, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QC check
3 participants