-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update QC criteria #952
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #952 +/- ##
========================================
Coverage 99.24% 99.24%
========================================
Files 28 29 +1
Lines 1713 1714 +1
========================================
+ Hits 1700 1701 +1
Misses 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…update-qc-criteria
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Vadym, I have some few comments
@ivadym Let me know when ready and I will merge the PR |
I think we still need approval from @ashwini06 and/or @khurrammaqbool as code owners. Maybe they can also come up with some ideas, suggestions on the implementation of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR:
Updates QC criteria for
panel
andwgs
analysis.Removes outdated balsamic report files (
balsamic_report.html
&balsamic_report.md
).Review and tests: