0.9.1 to master 3076a8b #247
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.9.1_to_cosmos-sdk-0.39-master #247 +/- ##
====================================================================
- Coverage 32.42% 19.80% -12.63%
====================================================================
Files 24 25 +1
Lines 3830 6419 +2589
====================================================================
+ Hits 1242 1271 +29
- Misses 2521 5079 +2558
- Partials 67 69 +2
Continue to review full report at Codecov.
|
| @@ -63,6 +63,19 @@ To set up a single node testnet, [look at the deployment documentation](./docs/d | |||
|
|
|||
| If you want to deploy a whole cluster, [look at the network scripts](./networks/README.md). | |||
|
|
|||
| ## Protobuf | |||
|
|
|||
| 1. Install [protoc](https://github.com/protocolbuffers/protobuf#protocol-compiler-installation) | |||
| addr, err := sdk.AccAddressFromBech32(bech) | ||
| if err != nil { | ||
| return nil, sdkerrors.Wrap(sdkerrors.ErrInvalidAddress, err.Error()) | ||
| type grpcQuerier struct { |
There was a problem hiding this comment.
I'd be curious for a quick explanation of the differences between the "LegacyQuerier" and the new grpc querier.
I am in the process of adding tendermint rpc queries to CosmJS and it would be great to understand this.
There was a problem hiding this comment.
LegacyQuerier is the handler for the the old rest queries in LCD. The grpc querier is a new endpoint to talk protobuf instead. I have not started it, yet so please consider the code WIP. There are also no tests for this.
There was a problem hiding this comment.
Please note the wasmcli rest-server command is not supported in this branch anymore.
wasmd start -h
...
--grpc.address string the gRPC server address to listen on (default "0.0.0.0:9090")
--grpc.enable Define if the gRPC server should be enabled (default true)
| } | ||
| } | ||
|
|
||
| // QueryContractInfoRequest is the request type for the Query/ContractInfo RPC method |
There was a problem hiding this comment.
Okay all requests and responses are defined here.
| @@ -79,7 +79,9 @@ type AppModule struct { | |||
| keeper Keeper | |||
| } | |||
|
|
|||
| func (am AppModule) RegisterQueryService(grpc.Server) {} | |||
| func (am AppModule) RegisterQueryService(server grpc.Server) { | |||
| types.RegisterQueryServer(server, NewQuerier(am.keeper)) | |||
There was a problem hiding this comment.
Okay, this is the key registration line for grpc.
|
What is needed to take this out of draft? |
|
I looked at the grpc stuff in cosmos sdk and got my head around it. We will have to migrate it all and test it, but piece by piece... it keeps changing and the stargate branch is mainly for in app IBC testing |
…ster * remotes/gaia/master: (38 commits) Merge PR CosmWasm#259: Bump SDK master commit Exec go mod tidy (CosmWasm#267) Merge PR CosmWasm#265: add version v2.0.5 to CHANGELOG Fix broken link in delegator guide (CosmWasm#262) docs: removed redundant readme.md (CosmWasm#261) Merge PR CosmWasm#258: Bump github.com/spf13/viper from 1.6.1 to 1.6.2 Merge PR CosmWasm#250: Docs-update Merge PR CosmWasm#256: Bump github.com/pkg/errors from 0.9.0 to 0.9.1 Merge PR CosmWasm#255: Bump github.com/pkg/errors from 0.8.1 to 0.9.0 Merge PR CosmWasm#253: Bump SDK master commit Merge PR CosmWasm#252: v2.0.4 Changelog Merge PR CosmWasm#249: docker image build and upload for release tags Merge PR CosmWasm#247: Update SDK Commit & Update CLI Doc Merge PR CosmWasm#246: Update Archive page with explorers Merge PR CosmWasm#245: archives Bump SDK commit to the latest master (CosmWasm#239) Merge PR CosmWasm#215: Update simulation tests Update join-mainnet.md (CosmWasm#229) Incorporate SDK's latest changes (CosmWasm#227) Merge PR CosmWasm#221: Hide unnecessarily exported function to better coverage report ...
Upgrade to latest master: