Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to stargate 034b478 #250

Closed
wants to merge 4 commits into from
Closed

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Aug 12, 2020

Replaces #172

  • query account is broken 7007

TODO:

  • some parameters for wasmcli are missing
  • manual tests

@alpe alpe changed the title Upgrade to stargate Upgrade to stargate 034b478 Aug 12, 2020
@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #250 into master will decrease coverage by 55.57%.
The diff coverage is 10.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #250       +/-   ##
===========================================
- Coverage   73.36%   17.78%   -55.58%     
===========================================
  Files          27       32        +5     
  Lines        2654    10450     +7796     
===========================================
- Hits         1947     1859       -88     
- Misses        594     8507     +7913     
+ Partials      113       84       -29     
Impacted Files Coverage Δ
x/wasm/internal/types/msg.go 52.67% <ø> (ø)
x/wasm/internal/types/query.pb.go 0.66% <ø> (ø)
x/wasm/internal/types/test_fixtures.go 93.46% <ø> (-0.41%) ⬇️
x/wasm/internal/types/types.go 23.27% <ø> (-0.41%) ⬇️
x/wasm/internal/types/types.pb.go 0.74% <ø> (ø)
x/wasm/module.go 16.32% <ø> (-0.70%) ⬇️
x/wasm/internal/types/proposal.pb.go 0.52% <0.52%> (ø)
x/wasm/internal/types/msg.pb.go 0.58% <0.58%> (ø)
x/wasm/internal/types/genesis.pb.go 0.82% <0.82%> (ø)
x/wasm/internal/types/codec.go 47.05% <18.18%> (-52.95%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a1dba...fa8d1ba. Read the comment docs.

@ethanfrey
Copy link
Member

It looks like cosmos/cosmos-sdk#7007 is closed. But did they fix this one? I couldn't see if the commit aaron referenced made it into master.

@ethanfrey
Copy link
Member

Replaced by #252

@ethanfrey ethanfrey closed this Aug 18, 2020
@alpe alpe deleted the 0.10_to_cosmos-stargate_rebase branch August 27, 2020 09:57
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
…ster

* remotes/gaia/master: (38 commits)
  Merge PR CosmWasm#259: Bump SDK master commit
  Exec go mod tidy (CosmWasm#267)
  Merge PR CosmWasm#265: add version v2.0.5 to CHANGELOG
  Fix broken link in delegator guide (CosmWasm#262)
  docs: removed redundant readme.md (CosmWasm#261)
  Merge PR CosmWasm#258: Bump github.com/spf13/viper from 1.6.1 to 1.6.2
  Merge PR CosmWasm#250: Docs-update
  Merge PR CosmWasm#256: Bump github.com/pkg/errors from 0.9.0 to 0.9.1
  Merge PR CosmWasm#255: Bump github.com/pkg/errors from 0.8.1 to 0.9.0
  Merge PR CosmWasm#253: Bump SDK master commit
  Merge PR CosmWasm#252: v2.0.4 Changelog
  Merge PR CosmWasm#249: docker image build and upload for release tags
  Merge PR CosmWasm#247: Update SDK Commit & Update CLI Doc
  Merge PR CosmWasm#246: Update Archive page with explorers
  Merge PR CosmWasm#245: archives
  Bump SDK commit to the latest master (CosmWasm#239)
  Merge PR CosmWasm#215: Update simulation tests
  Update join-mainnet.md (CosmWasm#229)
  Incorporate SDK's latest changes (CosmWasm#227)
  Merge PR CosmWasm#221: Hide unnecessarily exported function to better coverage report
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants