Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: persist search by example on page refresh #1606

Merged
merged 17 commits into from
Jul 29, 2023
Merged

fix: persist search by example on page refresh #1606

merged 17 commits into from
Jul 29, 2023

Conversation

Jami159
Copy link
Contributor

@Jami159 Jami159 commented Jul 28, 2023

Description

  • Make search by example persist when user refreshes the page or if they navigate back and forth using <- and -> buttons
  • Do some cleanup around how search by example was executed

YohannParis
YohannParis approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the huge cleanup

packages/client/hmi-client/src/page/data-explorer/DataExplorer.vue Outdated Show resolved Hide resolved
packages/client/hmi-client/src/page/data-explorer/components/tera-search-results-list.vue Outdated Show resolved Hide resolved
tangopapatime and others added 14 commits July 29, 2023 19:18
@tangopapatime @YohannParis @Jami159
fix: removed home resources (#1595)
45b40ff 
Co-authored-by: Yohann Paris <github@yohannparis.com>
@blanchco @YohannParis @Jami159
task: add resource filtering and new asset buttons (#1583)
bf426a8 
Co-authored-by: Cole Blanchard <cblanchard@Coles-MacBook-Pro.local>
Co-authored-by: Yohann Paris <github@yohannparis.com>
@echl @Jami159
feat: refactor of stratify drilldown typing; allow multi stratificati…
d774b47 
…on (#1596)
@mwdchang @Jami159
Remove assetname from url (#1592)
f8f8d9f
@jamiewaese-uncharted @Jami159
Jamie histogram design fix (#1598)
7da1f26
@shawnyama @Jami159
feat: editable matrices for stratified model configs (#1594)
505a010
@shawnyama @mwdchang
@Tom-Szendrey @Jami159
feat: multiple chart lines (#1552)
9e51436 
Co-authored-by: Daniel Chang <mwdchang@gmail.com>
Co-authored-by: Tom Szendrey <T.Szendrey@hotmail.com>
@tangopapatime @Jami159
fix: 1599 task updated related resources modal (#1600)
ead6dae
@blanchco @mwdchang @Jami159
Feat multi select dialog (#1597)
9428849 
Co-authored-by: Cole Blanchard <cblanchard@Coles-MacBook-Pro.local>
Co-authored-by: Daniel Chang <mwdchang@gmail.com>
@jamiewaese-uncharted @Jami159
Jamie dataset preview toggle histograms (#1586)
397aa2d
@mwdchang @Jami159
fix: weird formatting (#1603)
113e917
@blanchco @tangopapatime @Jami159
task: filter overview table (#1604)
968bd06 
Co-authored-by: Cole Blanchard <cblanchard@Coles-MacBook-Pro.local>
Co-authored-by: Thanh Pham <98172806+tangopapatime@users.noreply.github.com>
@mwdchang @Jami159
feat: pivot/matrix improvement for Catlab stratify (#1601)
3f27d0d
@Jami159
update typing and fix comments
8a4a19a
@Jami159 Jami159 requested review from dgauldie and dvince2 as code owners July 29, 2023 23:18
@Jami159 Jami159 merged commit 4f91b67 into main Jul 29, 2023
@Jami159 Jami159 deleted the persist_search_by_example branch July 29, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YohannParis YohannParis YohannParis approved these changes

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@dgauldie dgauldie Awaiting requested review from dgauldie

@dvince2 dvince2 Awaiting requested review from dvince2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Jami159 @YohannParis @tangopapatime @blanchco @echl @mwdchang @jamiewaese-uncharted @shawnyama